From: Jan Kiszka <jan.kiszka@web.de>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: kvm: fix information leak to userland
Date: Sat, 30 Oct 2010 17:46:10 +0200 [thread overview]
Message-ID: <4CCC3DC2.6090505@web.de> (raw)
In-Reply-To: <20101030153147.GA14169@albatros>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
Am 30.10.2010 17:31, Vasiliy Kulikov wrote:
> On Sat, Oct 30, 2010 at 16:34 +0200, Jan Kiszka wrote:
>> Am 30.10.2010 16:11, Vasiliy Kulikov wrote:
>>> Structure kvm_ppc_pvinfo is copied to userland with pad field
>>> unitialized. Structure kvm_clock_data is copied to userland with
>>> flags and pad fields unitialized. It leads to leaking of contents
>>> of kernel stack memory.
>>
>> This description only partially matches your patch, please fix.
>
> What do you mean? Two structures are copied with some fields with old
> stack values. Smth valuable else?
I mean you aren't touching ppc code in this patch, but you are fixing
more than just the kvm_clock interface.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2010-10-30 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 14:11 [PATCH v2] x86: kvm: fix information leak to userland Vasiliy Kulikov
2010-10-30 14:34 ` Jan Kiszka
2010-10-30 15:31 ` Vasiliy Kulikov
2010-10-30 15:46 ` Jan Kiszka [this message]
2010-10-30 18:54 ` [patch v2] x86: kvm: x86: " Vasiliy Kulikov
2010-11-01 17:19 ` Marcelo Tosatti
2011-07-26 17:05 ` Alexander Graf
2011-07-26 17:24 ` Avi Kivity
2011-07-26 17:38 ` Alexander Graf
2011-07-26 17:28 ` Vasiliy Kulikov
2011-07-26 17:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCC3DC2.6090505@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=segooon@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox