From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754632Ab0J3PqR (ORCPT ); Sat, 30 Oct 2010 11:46:17 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:34758 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217Ab0J3PqQ (ORCPT ); Sat, 30 Oct 2010 11:46:16 -0400 Message-ID: <4CCC3DC2.6090505@web.de> Date: Sat, 30 Oct 2010 17:46:10 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Vasiliy Kulikov CC: kernel-janitors@vger.kernel.org, Avi Kivity , Marcelo Tosatti , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86: kvm: fix information leak to userland References: <1288447871-7715-1-git-send-email-segooon@gmail.com> <4CCC2D11.7090109@web.de> <20101030153147.GA14169@albatros> In-Reply-To: <20101030153147.GA14169@albatros> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6C14A3F8D8FA9A6FABCF3241" X-Provags-ID: V01U2FsdGVkX19p2xq+uRvndoz/kSl6IpElq4IJCXylnGZ2R5XT dg/7cqwlfzb8DlhhkdY8HX+xRVg69iKf0IFWdnxHmKF+IZ5P5a 8Bo19SA8A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6C14A3F8D8FA9A6FABCF3241 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 30.10.2010 17:31, Vasiliy Kulikov wrote: > On Sat, Oct 30, 2010 at 16:34 +0200, Jan Kiszka wrote: >> Am 30.10.2010 16:11, Vasiliy Kulikov wrote: >>> Structure kvm_ppc_pvinfo is copied to userland with pad field >>> unitialized. Structure kvm_clock_data is copied to userland with >>> flags and pad fields unitialized. It leads to leaking of contents >>> of kernel stack memory. >> >> This description only partially matches your patch, please fix. >=20 > What do you mean? Two structures are copied with some fields with old > stack values. Smth valuable else? I mean you aren't touching ppc code in this patch, but you are fixing more than just the kvm_clock interface. Jan --------------enig6C14A3F8D8FA9A6FABCF3241 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAkzMPcUACgkQitSsb3rl5xQ8JgCfZqJQnjleqkRU2Zn/6GL8X12C InAAn2okk5zxAEp1qFMw6wOEL8o2oCy/ =lQYE -----END PGP SIGNATURE----- --------------enig6C14A3F8D8FA9A6FABCF3241--