From: Jiri Slaby <jirislaby@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Jiri Slaby <jslaby@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "Dr. Werner Fink" <werner@suse.de>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/1] console: add /proc/consoles
Date: Wed, 03 Nov 2010 21:03:42 +0100 [thread overview]
Message-ID: <4CD1C01E.1010309@gmail.com> (raw)
In-Reply-To: <20101103173944.GA6589@suse.de>
On 11/03/2010 06:39 PM, Greg KH wrote:
> On Wed, Nov 03, 2010 at 05:25:32PM +0100, Jiri Slaby wrote:
>> Actually where this code should be in fs/proc/? Most of the /proc/* is
>> handled elsewhere (fs/ mm/ kernel/). The rest is handled in specialized
>> fs/proc/FILE.c.
>
> What's wrong with putting it into fs/proc/proc_tty.c? That seems like
> the most logical thing to me...
consoles have little to do with ttys. Except ttys can be consoles. To me
it seems illogical to have info about netconsole, parallel consoles or
early serials somewhere in /proc/tty/. That's why I moved the info from
/proc/tty/ to /proc and the code from fs/proc/proc_tty.c to
kernel/printk.c where consoles are managed.
But if that makes less sense now than it did before, I will happily
switch it back.
regards,
--
js
next prev parent reply other threads:[~2010-11-03 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1288798509-23550-1-git-send-email-jslaby@suse.cz>
2010-11-03 16:13 ` [PATCH 1/1] console: add /proc/consoles Greg KH
2010-11-03 16:16 ` Jiri Slaby
2010-11-03 16:22 ` Greg KH
2010-11-03 16:25 ` Jiri Slaby
2010-11-03 17:39 ` Greg KH
2010-11-03 20:03 ` Jiri Slaby [this message]
2010-11-03 21:12 ` Greg KH
2010-11-04 9:57 ` Jiri Slaby
2010-11-04 13:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD1C01E.1010309@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=werner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox