* [PATCH] arm: Fix HAVE_S3C2410_WATCHDOG warnings
@ 2010-11-04 8:16 Kyungmin Park
2010-11-04 9:53 ` Abdoulaye Walsimou GAYE
2010-11-13 8:02 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Kyungmin Park @ 2010-11-04 8:16 UTC (permalink / raw)
To: Russell King, linux-arm-kernel; +Cc: linux-kernel, kgene
Fix build warnings
warning: (ARCH_S3C64XX && <choice> && WATCHDOG || ARCH_S5P64X0 && <choice> && WATCHDOG || ARCH_S5P6442 && <choice> && WATCHDOG || ARCH_S5PC100 && <choice> || ARCH_S5PV210 && <choice> || ARCH_S5PV310 && <choice> || MACH_SMDK6410 && ARCH_S3C64XX) selects HAVE_S3C2410_WATCHDOG which has unmet direct dependencies (WATCHDOG)
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index a19a526..a302713 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -677,7 +677,7 @@ config ARCH_S3C64XX
select USB_ARCH_HAS_OHCI
select SAMSUNG_GPIOLIB_4BIT
select HAVE_S3C2410_I2C
- select HAVE_S3C2410_WATCHDOG
+ select HAVE_S3C2410_WATCHDOG if WATCHDOG
help
Samsung S3C64XX series based systems
@@ -686,7 +686,7 @@ config ARCH_S5P64X0
select CPU_V6
select GENERIC_GPIO
select HAVE_CLK
- select HAVE_S3C2410_WATCHDOG
+ select HAVE_S3C2410_WATCHDOG if WATCHDOG
select ARCH_USES_GETTIMEOFFSET
select HAVE_S3C2410_I2C
select HAVE_S3C_RTC
@@ -700,7 +700,7 @@ config ARCH_S5P6442
select GENERIC_GPIO
select HAVE_CLK
select ARCH_USES_GETTIMEOFFSET
- select HAVE_S3C2410_WATCHDOG
+ select HAVE_S3C2410_WATCHDOG if WATCHDOG
help
Samsung S5P6442 CPU based systems
@@ -713,7 +713,7 @@ config ARCH_S5PC100
select ARCH_USES_GETTIMEOFFSET
select HAVE_S3C2410_I2C
select HAVE_S3C_RTC
- select HAVE_S3C2410_WATCHDOG
+ select HAVE_S3C2410_WATCHDOG if WATCHDOG
help
Samsung S5PC100 series based systems
@@ -728,7 +728,7 @@ config ARCH_S5PV210
select ARCH_USES_GETTIMEOFFSET
select HAVE_S3C2410_I2C
select HAVE_S3C_RTC
- select HAVE_S3C2410_WATCHDOG
+ select HAVE_S3C2410_WATCHDOG if WATCHDOG
help
Samsung S5PV210/S5PC110 series based systems
@@ -741,7 +741,7 @@ config ARCH_S5PV310
select GENERIC_CLOCKEVENTS
select HAVE_S3C_RTC
select HAVE_S3C2410_I2C
- select HAVE_S3C2410_WATCHDOG
+ select HAVE_S3C2410_WATCHDOG if WATCHDOG
help
Samsung S5PV310 series based systems
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: Fix HAVE_S3C2410_WATCHDOG warnings
2010-11-04 8:16 [PATCH] arm: Fix HAVE_S3C2410_WATCHDOG warnings Kyungmin Park
@ 2010-11-04 9:53 ` Abdoulaye Walsimou GAYE
[not found] ` <AANLkTim_YDa9k2LiiNTswhynGQCO=V_kEv1CpOMEZgN0@mail.gmail.com>
2010-11-13 8:02 ` Kukjin Kim
1 sibling, 1 reply; 4+ messages in thread
From: Abdoulaye Walsimou GAYE @ 2010-11-04 9:53 UTC (permalink / raw)
To: Kyungmin Park; +Cc: Russell King, linux-arm-kernel, kgene, linux-kernel
On 11/04/2010 09:16 AM, Kyungmin Park wrote:
> Fix build warnings
> warning: (ARCH_S3C64XX && <choice> && WATCHDOG || ARCH_S5P64X0 && <choice> && WATCHDOG || ARCH_S5P6442 && <choice> && WATCHDOG || ARCH_S5PC100 && <choice> || ARCH_S5PV210 && <choice> || ARCH_S5PV310 && <choice> || MACH_SMDK6410 && ARCH_S3C64XX) selects HAVE_S3C2410_WATCHDOG which has unmet direct dependencies (WATCHDOG)
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>
Kyungmin Park,
The same warning appears when I2C is not selected.
Best regards,
AWG
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] arm: Fix HAVE_S3C2410_WATCHDOG warnings
2010-11-04 8:16 [PATCH] arm: Fix HAVE_S3C2410_WATCHDOG warnings Kyungmin Park
2010-11-04 9:53 ` Abdoulaye Walsimou GAYE
@ 2010-11-13 8:02 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2010-11-13 8:02 UTC (permalink / raw)
To: 'Kyungmin Park', 'Russell King', linux-arm-kernel
Cc: linux-kernel
Kyungmin Park wrote:
>
> Fix build warnings
> warning: (ARCH_S3C64XX && <choice> && WATCHDOG || ARCH_S5P64X0 && <choice>
&&
> WATCHDOG || ARCH_S5P6442 && <choice> && WATCHDOG || ARCH_S5PC100 &&
<choice>
> || ARCH_S5PV210 && <choice> || ARCH_S5PV310 && <choice> || MACH_SMDK6410
&&
> ARCH_S3C64XX) selects HAVE_S3C2410_WATCHDOG which has unmet direct
> dependencies (WATCHDOG)
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a19a526..a302713 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -677,7 +677,7 @@ config ARCH_S3C64XX
> select USB_ARCH_HAS_OHCI
> select SAMSUNG_GPIOLIB_4BIT
> select HAVE_S3C2410_I2C
> - select HAVE_S3C2410_WATCHDOG
> + select HAVE_S3C2410_WATCHDOG if WATCHDOG
> help
> Samsung S3C64XX series based systems
>
> @@ -686,7 +686,7 @@ config ARCH_S5P64X0
> select CPU_V6
> select GENERIC_GPIO
> select HAVE_CLK
> - select HAVE_S3C2410_WATCHDOG
> + select HAVE_S3C2410_WATCHDOG if WATCHDOG
> select ARCH_USES_GETTIMEOFFSET
> select HAVE_S3C2410_I2C
> select HAVE_S3C_RTC
> @@ -700,7 +700,7 @@ config ARCH_S5P6442
> select GENERIC_GPIO
> select HAVE_CLK
> select ARCH_USES_GETTIMEOFFSET
> - select HAVE_S3C2410_WATCHDOG
> + select HAVE_S3C2410_WATCHDOG if WATCHDOG
> help
> Samsung S5P6442 CPU based systems
>
> @@ -713,7 +713,7 @@ config ARCH_S5PC100
> select ARCH_USES_GETTIMEOFFSET
> select HAVE_S3C2410_I2C
> select HAVE_S3C_RTC
> - select HAVE_S3C2410_WATCHDOG
> + select HAVE_S3C2410_WATCHDOG if WATCHDOG
> help
> Samsung S5PC100 series based systems
>
> @@ -728,7 +728,7 @@ config ARCH_S5PV210
> select ARCH_USES_GETTIMEOFFSET
> select HAVE_S3C2410_I2C
> select HAVE_S3C_RTC
> - select HAVE_S3C2410_WATCHDOG
> + select HAVE_S3C2410_WATCHDOG if WATCHDOG
> help
> Samsung S5PV210/S5PC110 series based systems
>
> @@ -741,7 +741,7 @@ config ARCH_S5PV310
> select GENERIC_CLOCKEVENTS
> select HAVE_S3C_RTC
> select HAVE_S3C2410_I2C
> - select HAVE_S3C2410_WATCHDOG
> + select HAVE_S3C2410_WATCHDOG if WATCHDOG
> help
> Samsung S5PV310 series based systems
Ok, will apply...
And will sort out other similar configure warning such as I2C and RTC.
As a note, in your patch, my e-mail address was wrong :-(
Anyway,
Thanks.
Have a nice weekend.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-13 8:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-04 8:16 [PATCH] arm: Fix HAVE_S3C2410_WATCHDOG warnings Kyungmin Park
2010-11-04 9:53 ` Abdoulaye Walsimou GAYE
[not found] ` <AANLkTim_YDa9k2LiiNTswhynGQCO=V_kEv1CpOMEZgN0@mail.gmail.com>
2010-11-04 12:30 ` Abdoulaye Walsimou GAYE
2010-11-13 8:02 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox