* [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile
@ 2010-11-06 19:03 Tracey Dent
2010-11-06 19:03 ` [PATCH 2/2] Drivers: dma: ioat: Makeile: " Tracey Dent
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tracey Dent @ 2010-11-06 19:03 UTC (permalink / raw)
To: dan.j.williams
Cc: akpm, linux-kernel, s.hauer, agust, linus.walleij, Tracey Dent
Use the ccflag-y instead of EXTRA_CFLAGS.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
drivers/dma/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index a8a84f4..64b21f5 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -1,8 +1,8 @@
ifeq ($(CONFIG_DMADEVICES_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
+ ccflags-y += -DDEBUG
endif
ifeq ($(CONFIG_DMADEVICES_VDEBUG),y)
- EXTRA_CFLAGS += -DVERBOSE_DEBUG
+ ccflags-y += -DVERBOSE_DEBUG
endif
obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
--
1.7.3.1.104.gc752e
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] Drivers: dma: ioat: Makeile: Cleaned up Makefile
2010-11-06 19:03 [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile Tracey Dent
@ 2010-11-06 19:03 ` Tracey Dent
2010-11-06 19:40 ` [PATCH 1/2] Drivers: dma: Makefile: " Dan Williams
2010-11-08 9:28 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Tracey Dent @ 2010-11-06 19:03 UTC (permalink / raw)
To: dan.j.williams
Cc: akpm, linux-kernel, s.hauer, agust, linus.walleij, Tracey Dent
Changed Makefile to use <modules>-y instead of <modules>-objs.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
drivers/dma/ioat/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/ioat/Makefile b/drivers/dma/ioat/Makefile
index 8997d3f..0ff7270 100644
--- a/drivers/dma/ioat/Makefile
+++ b/drivers/dma/ioat/Makefile
@@ -1,2 +1,2 @@
obj-$(CONFIG_INTEL_IOATDMA) += ioatdma.o
-ioatdma-objs := pci.o dma.o dma_v2.o dma_v3.o dca.o
+ioatdma-y := pci.o dma.o dma_v2.o dma_v3.o dca.o
--
1.7.3.1.104.gc752e
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile
2010-11-06 19:03 [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile Tracey Dent
2010-11-06 19:03 ` [PATCH 2/2] Drivers: dma: ioat: Makeile: " Tracey Dent
@ 2010-11-06 19:40 ` Dan Williams
2010-11-08 9:28 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2010-11-06 19:40 UTC (permalink / raw)
To: Tracey Dent
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
s.hauer@pengutronix.de, agust@denx.de,
linus.walleij@stericsson.com
On 11/06/2010 12:03 PM, Tracey Dent wrote:
> Use the ccflag-y instead of EXTRA_CFLAGS.
Thanks for the patch.
Please make the subject line: "drivers/dma/: Use the ccflag-y instead of
EXTRA_CFLAGS", and the description say why it is preferable to use
ccflag-y over EXTRA_CFLAGS.
That would make easy for me to judge why I should apply this.
Ditto for [PATCH 2/2]
--
Dan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile
2010-11-06 19:03 [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile Tracey Dent
2010-11-06 19:03 ` [PATCH 2/2] Drivers: dma: ioat: Makeile: " Tracey Dent
2010-11-06 19:40 ` [PATCH 1/2] Drivers: dma: Makefile: " Dan Williams
@ 2010-11-08 9:28 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2010-11-08 9:28 UTC (permalink / raw)
To: Tracey Dent
Cc: dan.j.williams@intel.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, s.hauer@pengutronix.de,
agust@denx.de
Tracey Dent wrote:
> Use the ccflag-y instead of EXTRA_CFLAGS.
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-08 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-06 19:03 [PATCH 1/2] Drivers: dma: Makefile: Cleaned up Makefile Tracey Dent
2010-11-06 19:03 ` [PATCH 2/2] Drivers: dma: ioat: Makeile: " Tracey Dent
2010-11-06 19:40 ` [PATCH 1/2] Drivers: dma: Makefile: " Dan Williams
2010-11-08 9:28 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox