Re: [2.6.37-rc1] sys_ioprio_set and RCU locking...

Paul E. McKenney
2010-11-09T21:50:50Z

On Tue, Nov 09, 2010 at 09:35:10PM +0100, Jens Axboe wrote:
> On 2010-11-08 14:55, Jens Axboe wrote:
> >>>>> Take the RCU lock for read across acquiring the pointer to the task
> >>>>> credentials and dereferencing it.
> >>>>
> >>>> Jens, does this look sane?
> >>>
> >>> Yes, looks clean enough to me.
> >>
> >> Very good! Are you willing to take the patch in your tree?
> >
> > Certainly, I'm in the middle of patch monkeying now anyway. Will queue
> > it up.
>
> The patch was buggy, I discovered that it does not do the proper
> RCU unlock if we fail the uid match. Merged version here:
>
> http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=1a882abdbf9579ad0e5655f928e4ede30db301e6

Ouch!!! I missed that one entirely, good catch!!!

Thanx, Paul