From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de,
Yinghai Lu <yinghai@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-64: more fixes and cleanup to AMD Fam10 MMCONF enabling
Date: Mon, 08 Nov 2010 08:13:09 -0800 [thread overview]
Message-ID: <4CD82195.6080905@zytor.com> (raw)
In-Reply-To: <4CD3F18E0200007800020B6D@vpn.id2.novell.com>
On 11/05/2010 03:59 AM, Jan Beulich wrote:
>
> --- 2.6.37-rc1-x86_64-mmconf-fam10h.orig/arch/x86/kernel/mmconf-fam10h_64.c
> +++ 2.6.37-rc1-x86_64-mmconf-fam10h/arch/x86/kernel/mmconf-fam10h_64.c
> @@ -43,7 +43,7 @@ static int __cpuinit cmp_range(const voi
> return start1 - start2;
> }
>
> -#define UNIT (1ULL << (5 + 3 + 12))
> +#define UNIT (1ULL << FAM10H_MMIO_CONF_BASE_SHIFT)
> #define MASK (~(UNIT - 1))
> #define SIZE (UNIT << 8)
Could we avoid macros named UNIT, MASK, and SIZE at all? I realize
they're already in the code, but still...
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-11-08 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 10:59 [PATCH] x86-64: more fixes and cleanup to AMD Fam10 MMCONF enabling Jan Beulich
2010-11-05 13:07 ` Andreas Herrmann
2010-11-05 13:13 ` Jan Beulich
2010-11-05 17:51 ` Yinghai Lu
2010-11-08 8:04 ` Jan Beulich
2010-11-10 19:22 ` Yinghai Lu
2010-11-08 16:13 ` H. Peter Anvin [this message]
2010-11-08 16:43 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD82195.6080905@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox