public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	hpa@zytor.com
Subject: Re: [PATCH] x86-64: fix and clean up AMD Fam10 MMCONF enabling
Date: Mon, 08 Nov 2010 11:20:34 -0800	[thread overview]
Message-ID: <4CD84D82.8020509@kernel.org> (raw)
In-Reply-To: <4CD7BC300200007800020E08@vpn.id2.novell.com>

On 11/08/2010 12:00 AM, Jan Beulich wrote:
>>>> On 05.11.10 at 20:02, Yinghai Lu <yinghai@kernel.org> wrote:
>>
>> looks like fam10h_pci_mmconf_base_status should NOT be removed.
>>
>> -1: mean we can not find right new base on BSP, so should not let AP to mess 
>> it again.
> 
> Note that is now achieved by clearing PCI_CHECK_ENABLE_AMD_MMCONF
> from pci_probe (imo a better way, as it inhibits code elsewhere which
> is protected by checks of this bit).

Then, please put that change in another patch.

Thanks

	Yinghai

      reply	other threads:[~2010-11-08 19:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04 15:22 [PATCH] x86-64: fix and clean up AMD Fam10 MMCONF enabling Jan Beulich
2010-11-05 17:56 ` Yinghai Lu
2010-11-05 19:02 ` Yinghai Lu
2010-11-08  8:00   ` Jan Beulich
2010-11-08 19:20     ` Yinghai Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD84D82.8020509@kernel.org \
    --to=yinghai@kernel.org \
    --cc=JBeulich@novell.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox