From: Suresh Jayaraman <sjayaraman@suse.de>
To: Andrew Hendry <andrew.hendry@gmail.com>
Cc: Steve French <smfrench@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-cifs@vger.kernel.org
Subject: Re: 2.6.37-rc1 kmemleak warnings when saving a file over cifs.
Date: Tue, 09 Nov 2010 12:35:13 +0530 [thread overview]
Message-ID: <4CD8F2A9.6080907@suse.de> (raw)
In-Reply-To: <AANLkTi=nDY25GNpV=XVum0Cbg1tjX14v-fcA2K6NrhgW@mail.gmail.com>
On 11/09/2010 11:31 AM, Andrew Hendry wrote:
> The server is a qnap NAS, running linux 2.6.24
> On Tue, Nov 9, 2010 at 3:12 PM, Steve French <smfrench@gmail.com> wrote:
>> On Mon, Nov 8, 2010 at 6:13 PM, Andrew Hendry <andrew.hendry@gmail.com> wrote:
>>> Have just noticed these in the past few days, now running 2.6.37-rc1+
>>> Seems to be 1 logged per file save when using a text file with gedit over cifs.
>>
>> Can you tell the called function in cifs_setattr_unix vs. cifs_setattr_nounix
>> (the former will usually be called when the server is Samba, the latter
>> when the server is Windows or NetApp). �What is the server type?
>>
>>> unreferenced object 0xffff88022ee08b40 (size 32):
>>> �comm "gedit", pid 2524, jiffies 4300160388 (age 2633.655s)
>>> �hex dump (first 32 bytes):
>>> � �5c 2e 67 6f 75 74 70 75 74 73 74 72 65 61 6d 2d �\.goutputstream-
>>> � �35 42 41 53 4c 56 00 de 09 00 00 00 2c 26 78 ee �5BASLV......,&x.
>>> �backtrace:
>>> � �[<ffffffff81504a4d>] kmemleak_alloc+0x2d/0x60
>>> � �[<ffffffff81136e13>] __kmalloc+0xe3/0x1d0
>>> � �[<ffffffffa0313db0>] build_path_from_dentry+0xf0/0x230 [cifs]
>>> � �[<ffffffffa031ae1e>] cifs_setattr+0x9e/0x770 [cifs]
>>> � �[<ffffffff8115fe90>] notify_change+0x170/0x2e0
>>> � �[<ffffffff81145ceb>] sys_fchmod+0x10b/0x140
>>> � �[<ffffffff8100c172>] system_call_fastpath+0x16/0x1b
>>> � �[<ffffffffffffffff>] 0xffffffffffffffff
>>
Are you using the mount option 'nounix'? I spotted a memleak in the
nounix code path introduced by a recent patch and proposed a fix here:
http://thread.gmane.org/gmane.linux.kernel.cifs/1549
Does this fix the leak for you?
--
Suresh Jayaraman
next prev parent reply other threads:[~2010-11-09 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 0:13 2.6.37-rc1 kmemleak warnings when saving a file over cifs Andrew Hendry
2010-11-09 4:12 ` Steve French
2010-11-09 6:01 ` Andrew Hendry
2010-11-09 7:05 ` Suresh Jayaraman [this message]
2010-11-09 11:17 ` Andrew Hendry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD8F2A9.6080907@suse.de \
--to=sjayaraman@suse.de \
--cc=andrew.hendry@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox