Re: [PATCH 4/6] ce4100: Add errata fixes for UART on CE4100

[Dirk Brandewie <dirk.brandewie@gmail.com>]

On 11/11/2010 03:34 AM, Thomas Gleixner wrote:
>
>
>> +	 * Over ride the legacy port configuration that comes from
>> +	 * asm/serial.h. Using the ioport driver then switching to the
>> +	 * PCI memmaped driver hangs the IOAPIC
>> +	 */
>> +	if (up->iotype !=  UPIO_MEM32) {
>> +		up->uartclk  = 14745600;
>> +		up->mapbase = 0xdffe0200;
>
>    What does the uartclk, mapbase fixups in the CONFIG_EARLY_PRINTK=n case ?
>
This is setup in the PCI driver patch #3 in the series

>> +		set_fixmap_nocache(FIX_EARLYCON_MEM_BASE,
>> +				up->mapbase&  PAGE_MASK);
>> +		up->membase =
>> +			(void __iomem *)__fix_to_virt(FIX_EARLYCON_MEM_BASE);
>> +		up->membase += up->mapbase&  ~PAGE_MASK;
>> +		up->iotype   = UPIO_MEM32;
>> +		up->regshift = 2;
>> +	}
>> +#endif
>> +	up->iobase = 0;
>> +	up->serial_in = ce4100_mem_serial_in;
>> +	up->serial_out = ce4100_mem_serial_out;
>> +
>> +	*capabilites |= (1<<  12);
>> +}
>
> Thanks,
>
> 	tglx