From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] KVM: MMU: retry #PF for softmmu
Date: Sun, 14 Nov 2010 12:46:24 +0200 [thread overview]
Message-ID: <4CDFBE00.2000802@redhat.com> (raw)
In-Reply-To: <4CDCE3C2.9030107@cn.fujitsu.com>
On 11/12/2010 08:50 AM, Xiao Guangrong wrote:
> Retry #PF for softmmu only when the current vcpu has the same
> root shadow page as the time when #PF occurs. it means they
> have same paging environment
>
The process could have been killed and replaced by another using the
same cr3. Or we may be running a guest that uses the same cr3 for all
processes. Or another thread may have mmap()ed something else over the
same address. So I think this is incorrect.
Meanwhile, I applied patches 1-4.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-11-14 10:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 6:46 [PATCH v2 1/5] KVM: MMU: fix missing post sync audit Xiao Guangrong
2010-11-12 6:47 ` [PATCH v2 2/5] KVM: MMU: clear apfs if page state is changed Xiao Guangrong
2010-11-12 6:49 ` [PATCH v2 3/5] KVM: MMU: support apf for nonpaing guest Xiao Guangrong
2010-11-12 6:49 ` [PATCH v2 4/5] KVM: MMU: fix apf prefault if nested guest is enabled Xiao Guangrong
2010-11-12 6:50 ` [PATCH v2 5/5] KVM: MMU: retry #PF for softmmu Xiao Guangrong
2010-11-14 10:46 ` Avi Kivity [this message]
2010-11-15 5:25 ` Xiao Guangrong
2010-11-15 9:30 ` Avi Kivity
2010-11-15 9:55 ` Xiao Guangrong
2010-11-15 9:56 ` Gleb Natapov
2010-11-15 9:59 ` Avi Kivity
2010-11-15 10:12 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDFBE00.2000802@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox