From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andres Salomon <dilinger@queued.net>,
Milton Miller <miltonm@bga.com>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2)
Date: Sun, 14 Nov 2010 20:21:34 -0800 [thread overview]
Message-ID: <4CE0B54E.6000101@zytor.com> (raw)
In-Reply-To: <20101114095013.GB24206@elte.hu>
On 11/14/2010 01:50 AM, Ingo Molnar wrote:
>
> It's being frowned upon btw, because it's easy to overlook (and for other reasons) -
> please dont use statics inside functions - please put them in front of the function
> or further up into file scope.
>
What? What is wrong with static variables in functions? It really
doesn't seem to be a good idea to make them file-scope if they don't
need to be.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-11-15 4:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 5:45 [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2) Andres Salomon
2010-11-12 7:48 ` Milton Miller
2010-11-12 8:27 ` Andres Salomon
2010-11-14 9:50 ` Ingo Molnar
2010-11-15 4:21 ` H. Peter Anvin [this message]
2010-11-15 7:02 ` Ingo Molnar
2010-11-15 17:43 ` H. Peter Anvin
2010-11-17 6:12 ` [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v3) Andres Salomon
2010-11-29 23:39 ` [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v4) Andres Salomon
2010-12-16 2:58 ` [tip:x86/olpc] x86, olpc: Speed up device tree creation during boot tip-bot for Andres Salomon
2010-11-18 8:34 ` [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2) Ingo Molnar
2010-11-18 11:02 ` Michael Ellerman
2010-11-18 15:04 ` H. Peter Anvin
2010-11-18 17:41 ` Andres Salomon
2010-11-18 17:48 ` H. Peter Anvin
2010-11-19 20:24 ` Andres Salomon
2010-12-23 11:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE0B54E.6000101@zytor.com \
--to=hpa@zytor.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox