From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Xen-devel] Re: [PATCH 3/3] xen/microcode: partially enable even for non-privileged kernels
Date: Mon, 15 Nov 2010 17:17:20 -0800 [thread overview]
Message-ID: <4CE1DBA0.4010302@goop.org> (raw)
In-Reply-To: <20101115160245.GD345@dumpdata.com>
On 11/15/2010 08:02 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Nov 11, 2010 at 03:58:06PM -0800, Jeremy Fitzhardinge wrote:
>> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>>
>> Don't attempt to load microcode on non-privileged kernels. Kernels
> The previous patch had this:
>
> if (!xen_initial_domain())
> + return NULL;
>
> which pretty much made non-priviliged kernels not do any micro code loading.
>
> It sounds like this patch is just to not compile the Xen microcode code
> if CONFIG_DOM0 is not enabled?
Yeah, I think the patch is a brainfart, and the existing code already
did the right thing.
J
prev parent reply other threads:[~2010-11-16 1:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 23:58 [PATCH 0/3] Xen Microcode update driver for 2.6.38 Jeremy Fitzhardinge
2010-11-11 23:58 ` [PATCH 1/3] xen dom0: Add support for the platform_ops hypercall Jeremy Fitzhardinge
2010-11-15 15:48 ` Konrad Rzeszutek Wilk
2010-11-16 1:14 ` [Xen-devel] " Jeremy Fitzhardinge
2010-11-16 15:52 ` Konrad Rzeszutek Wilk
2010-11-11 23:58 ` [PATCH 2/3] xen: add CPU microcode update driver Jeremy Fitzhardinge
2010-11-15 15:59 ` Konrad Rzeszutek Wilk
2010-11-16 1:16 ` [Xen-devel] " Jeremy Fitzhardinge
2010-11-11 23:58 ` [PATCH 3/3] xen/microcode: partially enable even for non-privileged kernels Jeremy Fitzhardinge
2010-11-15 16:02 ` Konrad Rzeszutek Wilk
2010-11-16 1:17 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE1DBA0.4010302@goop.org \
--to=jeremy@goop.org \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox