From: "Pádraig Brady" <P@draigBrady.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] Ext4: fail if we try to use hole punch
Date: Tue, 16 Nov 2010 16:56:39 +0000 [thread overview]
Message-ID: <4CE2B7C7.4080406@draigBrady.com> (raw)
In-Reply-To: <20101116163320.GB2524@localhost.localdomain>
On 16/11/10 16:33, Josef Bacik wrote:
> On Tue, Nov 16, 2010 at 04:20:43PM +0000, Pádraig Brady wrote:
>>
>> So for older versions of ext4 or other filesystems, how do we know
>> that fallocate(...,FALLOC_FL_PUNCH_HOLE) is not supported.
>> I.E. how do we detect at runtime that the call succeeded
>> and didn't just do a normal fallocate()?
>>
>
> Older kernels won't accept FALLOC_FL_PUNCH_HOLE, so you'll get an error.
> Thanks,
Oops right.
Older kernels filter FALLOC_FL_PUNCH_HOLE at a higher level in fs/open.c
Whereas newer kernels will do it per file system.
thanks,
Pádraig.
next prev parent reply other threads:[~2010-11-16 16:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:05 Hole Punching V2 Josef Bacik
2010-11-15 17:05 ` [PATCH 1/6] fs: add hole punching to fallocate Josef Bacik
2010-11-16 11:16 ` Jan Kara
2010-11-16 11:43 ` Jan Kara
2010-11-16 12:52 ` Josef Bacik
2010-11-16 13:14 ` Jan Kara
2010-11-17 0:22 ` Andreas Dilger
2010-11-17 2:11 ` Dave Chinner
2010-11-17 2:28 ` Josef Bacik
2010-11-17 2:34 ` Josef Bacik
2010-11-17 9:30 ` Andreas Dilger
2010-11-17 9:19 ` Andreas Dilger
2010-11-16 12:53 ` Josef Bacik
2010-11-15 17:05 ` [PATCH 2/6] XFS: handle hole punching via fallocate properly Josef Bacik
2010-11-15 17:05 ` [PATCH 3/6] Ocfs2: " Josef Bacik
2010-11-16 11:50 ` Jan Kara
2010-11-17 23:27 ` Joel Becker
2010-11-15 17:05 ` [PATCH 4/6] Ext4: fail if we try to use hole punch Josef Bacik
2010-11-16 11:52 ` Jan Kara
2010-11-16 12:25 ` Avi Kivity
2010-11-16 12:50 ` Josef Bacik
2010-11-16 13:07 ` Avi Kivity
2010-11-16 16:05 ` Josef Bacik
2010-11-16 20:47 ` Greg Freemyer
2010-11-17 3:06 ` Ted Ts'o
2010-11-17 6:31 ` Josef Bacik
2010-11-16 16:20 ` Pádraig Brady
2010-11-16 16:33 ` Josef Bacik
2010-11-16 16:56 ` Pádraig Brady [this message]
2010-11-15 17:05 ` [PATCH 5/6] Btrfs: " Josef Bacik
2010-11-15 17:05 ` [PATCH 6/6] Gfs2: " Josef Bacik
-- strict thread matches above, loose matches on Subject: below --
2010-11-18 1:46 Hole Punching V3 Josef Bacik
2010-11-18 1:46 ` [PATCH 4/6] Ext4: fail if we try to use hole punch Josef Bacik
2010-11-08 20:32 [PATCH 1/6] fs: add hole punching to fallocate Josef Bacik
2010-11-08 20:32 ` [PATCH 4/6] Ext4: fail if we try to use hole punch Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2B7C7.4080406@draigBrady.com \
--to=p@draigbrady.com \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox