From: Jens Axboe <jaxboe@fusionio.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cciss: fix build for PROC_FS disabled
Date: Wed, 17 Nov 2010 11:58:15 +0100 [thread overview]
Message-ID: <4CE3B547.7050907@fusionio.com> (raw)
In-Reply-To: <AANLkTimE_y=GFP+Sg-MYvEfQyg7GtzGRs+gdqjzOZm-_@mail.gmail.com>
On 2010-11-17 03:56, Linus Torvalds wrote:
> On Tue, Nov 16, 2010 at 5:00 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>
>> Fix cciss driver for CONFIG_PROC_FS not enabled:
>>
>> drivers/block/cciss.c:4929: error: 'proc_cciss' undeclared (first use in this function)
>
> Hmm. I would almost prefer to not have this #ifdef inside code, and
> solve it by simply moving the definition of "proc_cciss" to outside
> the other #ifdef CONFIG_PROC_FS.
>
> That way it allways stays NULL, and without CONFIG_PROC_FS the code in
> question will all be empty inline function calls anyway, so the
> compiler will compile it all away (at the cost of just keeping that
> one unnecessary variable around).
>
> I'd rather waste one useless pointer than have ugly source code.
>
> Comments?
Agree, I merged this:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=bbe425cd9ae83eacd0c9f09df2bf56dc911a54cd
--
Jens Axboe
prev parent reply other threads:[~2010-11-17 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 3:12 Linux 2.6.37-rc2 Linus Torvalds
2010-11-16 20:35 ` Zimny Lech
2010-11-17 0:59 ` [PATCH] acpi: fix acpi/video.h error and warning when PM is not enabled Randy Dunlap
2010-11-17 1:29 ` Zhang Rui
2010-11-17 16:06 ` Randy Dunlap
2010-11-17 1:00 ` [PATCH] cciss: fix build for PROC_FS disabled Randy Dunlap
2010-11-17 2:56 ` Linus Torvalds
2010-11-17 10:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE3B547.7050907@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).