From: Timur Tabi <timur@freescale.com>
To: Greg KH <gregkh@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Stuart Yoder <stuart.yoder@freescale.com>
Subject: Re: How do I choose an arbitrary minor number for my tty device?
Date: Wed, 17 Nov 2010 16:42:22 -0600 [thread overview]
Message-ID: <4CE45A4E.70308@freescale.com> (raw)
In-Reply-To: <20101117221903.GA4066@suse.de>
Greg KH wrote:
> I think you are forgetting that your byte channel devices must be
> "devices" in the system here, right? There is a 'struct bus_id" for
> your bus that these devices live on.
Do you mean "struct bus_type"? I don't have any concept of a "bus" in my
driver. I didn't know I needed to create one, and I'm not sure how, either.
I guess my real problem is that I'm not really sure what I should be doing. I
already have a plain character driver that creates devices for each byte
channel. First I call alloc_chrdev_region() to get a started dev_id. Then I
iterate over the byte channels and call device_create() for each one, with NULL
for the parent. At the end, I call cdev_init() and cdev_add().
Now I'm trying to register these byte channels as tty devices, because I'd like
to use them for the system console, and not just plain character devices. My
plan was to just call tty_register_device() instead of device_create(), so I
don't understand where the "bus" comes in. What bus?
> Then you create a tty device in
> your tty driver that attaches to the byte channel that shows up as a tty
> device on your bus.
Are you saying that when I call tty_register_device(), the third parameter
should be the return value from the previous call to device_create(), like this:
bc->dev_id = MKDEV(MAJOR(dev_id), MINOR(dev_id) + i);
bc->dev = device_create(ehv_bc_class, NULL, bc->dev_id, bc, "bc%u", bc->handle);
tty_register_device(ehv_bc_driver, MINOR(bc->dev_id), bc->dev);
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-11-17 22:42 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 21:37 How do I choose an arbitrary minor number for my tty device? Timur Tabi
2010-11-17 21:51 ` Greg KH
2010-11-17 22:10 ` Timur Tabi
2010-11-17 22:19 ` Greg KH
2010-11-17 22:42 ` Timur Tabi [this message]
2010-11-18 2:24 ` Greg KH
2010-11-18 15:31 ` Timur Tabi
2010-11-18 15:39 ` Greg KH
2010-11-18 16:03 ` Timur Tabi
2010-11-18 16:33 ` Greg KH
2010-11-18 16:36 ` Timur Tabi
2010-11-18 16:51 ` Greg KH
2010-11-18 16:56 ` Timur Tabi
2010-11-18 17:18 ` Greg KH
2010-11-18 17:38 ` Timur Tabi
2010-11-18 17:58 ` Greg KH
2010-11-18 19:35 ` Timur Tabi
2010-11-18 20:02 ` Greg KH
2010-11-18 20:06 ` Timur Tabi
2010-11-18 20:10 ` Greg KH
2010-11-18 20:43 ` Timur Tabi
2010-11-18 20:56 ` Alan Cox
2010-11-22 16:32 ` Timur Tabi
2010-11-22 20:12 ` Timur Tabi
2010-11-23 13:56 ` Alan Cox
2010-11-23 17:14 ` Timur Tabi
2010-11-23 23:03 ` Alan Cox
2010-11-18 20:58 ` Alan Cox
2010-11-18 17:21 ` Scott Wood
2010-11-18 17:42 ` Timur Tabi
2010-11-18 17:58 ` Greg KH
2010-11-18 18:13 ` Scott Wood
2010-11-24 10:23 ` Michael Ellerman
2010-11-24 18:08 ` Scott Wood
2010-11-24 18:23 ` Greg KH
2010-11-24 22:44 ` Michael Ellerman
2010-11-29 21:44 ` Greg KH
2010-11-29 21:51 ` Timur Tabi
2010-11-29 22:30 ` Greg KH
2010-11-29 22:36 ` Timur Tabi
2010-11-30 3:29 ` Greg KH
2010-11-30 4:15 ` Tabi Timur-B04825
2010-11-30 19:33 ` Timur Tabi
2010-12-01 1:00 ` Greg KH
2010-12-01 9:54 ` Kay Sievers
2010-12-02 16:12 ` Timur Tabi
2010-11-24 22:46 ` Michael Ellerman
2010-11-25 4:10 ` Grant Likely
2010-11-24 18:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE45A4E.70308@freescale.com \
--to=timur@freescale.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox