From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Darren Hart <dvhart@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"jason.wessel" <jason.wessel@windriver.com>,
"Ted Ts'o" <tytso@mit.edu>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [RFC][PATCH 2/2] [PATCH 2/2] tracing: Make event based trace_printk()
Date: Thu, 18 Nov 2010 13:50:06 +0800 [thread overview]
Message-ID: <4CE4BE8E.8060509@cn.fujitsu.com> (raw)
In-Reply-To: <20101118040949.782054673@goodmis.org>
On 11/18/2010 11:58 AM, Steven Rostedt wrote:
> +#define trace_printk(fmt, args...) \
> + do { \
> + static struct event_printk_struct \
> + __attribute__((__aligned__(4))) \
> + __attribute__((section("_trace_printk"))) \
> + ______t = { \
> + .format = fmt, \
if fmt is not constant, the compiler will complain...
> + .func = __func__, \
> + .file = __FILE__, \
> + .line = __LINE__, \
> + }; \
> + __trace_printk_check_format(fmt, ##args); \
> + if (!__builtin_constant_p(fmt)) \
> + trace_printk_can_only_have_constant_format(); \
so this is not need.
> + if (unlikely(__event_printk_test(&______t.enable))) \
> + __trace_bprintk(_THIS_IP_, fmt, ##args); \
> + } while (0)
next prev parent reply other threads:[~2010-11-18 5:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 3:58 [RFC][PATCH 0/2] tracing: Have trace_printk()s in the events/ directory Steven Rostedt
2010-11-18 3:58 ` [RFC][PATCH 1/2] [PATCH 1/2] tracing: Rename trace_printk to ftrace_printk Steven Rostedt
2010-11-18 3:58 ` [RFC][PATCH 2/2] [PATCH 2/2] tracing: Make event based trace_printk() Steven Rostedt
2010-11-18 4:19 ` Steven Rostedt
2010-11-18 5:50 ` Lai Jiangshan [this message]
2010-11-18 12:22 ` Steven Rostedt
2010-11-18 11:58 ` Mathieu Desnoyers
2010-11-18 12:14 ` Steven Rostedt
2010-11-18 10:41 ` [RFC][PATCH 0/2] tracing: Have trace_printk()s in the events/ directory Peter Zijlstra
2010-11-18 11:53 ` Steven Rostedt
2010-11-18 12:06 ` Mathieu Desnoyers
2010-11-18 12:14 ` Steven Rostedt
2010-11-18 13:03 ` Mathieu Desnoyers
2010-11-18 12:53 ` Frederic Weisbecker
2010-11-18 13:06 ` Steven Rostedt
2010-11-18 14:02 ` Frederic Weisbecker
2010-11-18 13:21 ` Peter Zijlstra
2010-11-18 13:36 ` Frederic Weisbecker
2010-11-18 12:39 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE4BE8E.8060509@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=dvhart@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox