From: Lars-Peter Clausen <lars@metafoo.de>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: rklein@nvidia.com, broonie@opensource.wolfsonmicro.com,
achew@nvidia.com, olof@lixom.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] POWER: Add gpio charger driver
Date: Thu, 18 Nov 2010 15:30:09 +0100 [thread overview]
Message-ID: <4CE53871.6080004@metafoo.de> (raw)
In-Reply-To: <20101118140522.GD19527@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:
>> This patch adds a simple driver for chargers indicating their online status
>> through a GPIO pin.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>>
>> ---
>> Changes since v1
>> * Fix typo in Kconfig
>> * Fix whitespace issues
>> * Add missing includes in the header file
>> * Make the irq field of the driver struct unsigned and assume that 0 is not a
>> valid irq.
>
> Applied, thanks!
>
> But please, look at Mark Brown comments. If they are still
> applicable, the follow up patch would be great.
>
> Thanks!
>
Hi
I'll send a follow up patch later today. I think I had one or two other issues on my
list that need to be addressed.
I wanted to wait with v3 until it was clear whether the driver had a chance to be
merged at all.
Do you prefer a v3 of the original patch or an incremental one?
- Lars
next prev parent reply other threads:[~2010-11-18 14:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 0:56 [PATCH v2] power: bq24617: Adding initial charger support rklein
2010-10-21 12:20 ` Lars-Peter Clausen
2010-10-21 12:25 ` [PATCH] POWER: Add gpio chager driver Lars-Peter Clausen
2010-10-21 12:43 ` Piotr Hosowicz
2010-10-21 14:53 ` Lars-Peter Clausen
2010-10-21 14:14 ` Anton Vorontsov
2010-10-21 14:52 ` Lars-Peter Clausen
2010-10-21 15:05 ` Anton Vorontsov
2010-10-21 17:22 ` Rhyland Klein
2010-10-21 15:55 ` [PATCH v2] POWER: Add gpio charger driver Lars-Peter Clausen
2010-10-21 16:00 ` Mark Brown
2010-10-21 16:16 ` Lars-Peter Clausen
2010-10-21 16:19 ` Mark Brown
2010-10-21 16:26 ` Anton Vorontsov
2010-10-21 17:47 ` Lars-Peter Clausen
2010-10-22 21:41 ` Rhyland Klein
2010-10-28 21:17 ` Rhyland Klein
2010-11-04 17:47 ` Anton Vorontsov
2010-11-11 0:53 ` Rhyland Klein
2010-11-11 1:33 ` Lars-Peter Clausen
2010-11-11 1:46 ` Rhyland Klein
2010-11-17 1:37 ` Rhyland Klein
2010-11-18 14:05 ` Anton Vorontsov
2010-11-18 14:30 ` Lars-Peter Clausen [this message]
2010-11-18 14:42 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE53871.6080004@metafoo.de \
--to=lars@metafoo.de \
--cc=achew@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).