public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Greg KH <gregkh@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Scott Wood <scottwood@freescale.com>,
	Stuart Yoder <stuart.yoder@freescale.com>
Subject: Re: How do I choose an arbitrary minor number for my tty device?
Date: Thu, 18 Nov 2010 10:03:12 -0600	[thread overview]
Message-ID: <4CE54E40.9040503@freescale.com> (raw)
In-Reply-To: <20101118153912.GA1443@suse.de>

Greg KH wrote:
>> > 
>> > I'm still not sure why you think I have a bus.  I don't see where the UART
>> > drivers register a bus, and there's not a whole lot different between a byte
>> > channel and a UART.

> But they are obviously two different things, right?

Well, sure.  A byte channel is just a software concept.  You can send data,
receive data, and poll a byte channel.  You can't set the baud rate, or send
break signals or even do flow control.  I debated making the driver act like a
fake serial device, which probably would have been easier but not "correct".

Unfortunately, I seem to lack some fundamental understanding of tty drivers that
is making my life difficult.  I've been reading all the documentation that I can
get my hands on, as well as studying a lot of source code, but I still can't
find any example to base *my* code on.  I just don't know if what I'm doing is
right.

I still don't know how to connect the byte channel handle with the /dev entry.
That's the question my original post asked, and I still don't have an answer to it.

> Why not?  It sounds like there should be, right?  That would make things
> much easier for you in the end from what I can tell.

I'm not so sure.  Like I said, I still don't see where there's a bus.  I have a
single driver that has multiple devices.  It sounds to me like one call to
tty_register_driver() and multiple calls to tty_register_device() would be
sufficient.

For instance, there is no code in drivers/char/ that makes a call to
bus_register(), so I don't see any precedent for a tty driver to register a bus
first.

Also, this is an Open Firmware driver.  I already have a mechanism whereby I get
probed for each instance of a byte channel.  Isn't that my "bus"?

I'm really trying to do the right thing here, Greg, but every time I try to
solve one problem, I'm being told that I need to make things way more
complicated first.

-- 
Timur Tabi
Linux kernel developer at Freescale


  reply	other threads:[~2010-11-18 16:05 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 21:37 How do I choose an arbitrary minor number for my tty device? Timur Tabi
2010-11-17 21:51 ` Greg KH
2010-11-17 22:10   ` Timur Tabi
2010-11-17 22:19     ` Greg KH
2010-11-17 22:42       ` Timur Tabi
2010-11-18  2:24         ` Greg KH
2010-11-18 15:31           ` Timur Tabi
2010-11-18 15:39             ` Greg KH
2010-11-18 16:03               ` Timur Tabi [this message]
2010-11-18 16:33                 ` Greg KH
2010-11-18 16:36                   ` Timur Tabi
2010-11-18 16:51                     ` Greg KH
2010-11-18 16:56                       ` Timur Tabi
2010-11-18 17:18                         ` Greg KH
2010-11-18 17:38                           ` Timur Tabi
2010-11-18 17:58                             ` Greg KH
2010-11-18 19:35                               ` Timur Tabi
2010-11-18 20:02                                 ` Greg KH
2010-11-18 20:06                                   ` Timur Tabi
2010-11-18 20:10                                     ` Greg KH
2010-11-18 20:43                                       ` Timur Tabi
2010-11-18 20:56                                         ` Alan Cox
2010-11-22 16:32                                           ` Timur Tabi
2010-11-22 20:12                                             ` Timur Tabi
2010-11-23 13:56                                             ` Alan Cox
2010-11-23 17:14                                               ` Timur Tabi
2010-11-23 23:03                                                 ` Alan Cox
2010-11-18 20:58                                 ` Alan Cox
2010-11-18 17:21                 ` Scott Wood
2010-11-18 17:42                   ` Timur Tabi
2010-11-18 17:58                     ` Greg KH
2010-11-18 18:13                     ` Scott Wood
2010-11-24 10:23                       ` Michael Ellerman
2010-11-24 18:08                         ` Scott Wood
2010-11-24 18:23                           ` Greg KH
2010-11-24 22:44                             ` Michael Ellerman
2010-11-29 21:44                               ` Greg KH
2010-11-29 21:51                                 ` Timur Tabi
2010-11-29 22:30                                   ` Greg KH
2010-11-29 22:36                                     ` Timur Tabi
2010-11-30  3:29                                       ` Greg KH
2010-11-30  4:15                                         ` Tabi Timur-B04825
2010-11-30 19:33                                         ` Timur Tabi
2010-12-01  1:00                                           ` Greg KH
2010-12-01  9:54                                             ` Kay Sievers
2010-12-02 16:12                                               ` Timur Tabi
2010-11-24 22:46                           ` Michael Ellerman
2010-11-25  4:10                             ` Grant Likely
2010-11-24 18:13                         ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE54E40.9040503@freescale.com \
    --to=timur@freescale.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scottwood@freescale.com \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox