Re: [35/45] USB: atmel_usba_udc: force vbus_pin at -EINVAL when gpio_request failled

[Nicolas Ferre <nicolas.ferre@atmel.com>]

Le 19/11/2010 22:43, Greg KH :
> 2.6.32-stable review patch.  If anyone has any objections, please let us know.

Hi Greg,

Please also add this typo one (or merge it): 

http://git.kernel.org/?p=linux/kernel/git/gregkh/usb-2.6.git;a=commit;h=b48809518631880207796b4aab0fc39c2f036754

Thanks a lot for monitoring this issue and adding to -stable...

Best regards,
 
> ------------------
> 
> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> commit 969affff54702785330de553b790372e261e93f9 upstream.
> 
> to ensure gpio_is_valid return false
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> ---
>  drivers/usb/gadget/atmel_usba_udc.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -2013,6 +2013,9 @@ static int __init usba_udc_probe(struct
>  			} else {
>  				disable_irq(gpio_to_irq(udc->vbus_pin));
>  			}
> +		} else {
> +			/* gpio_request fail so use -EINVAL for gpio_is_valid */
> +			ubc->vbus_pin = -EINVAL;
>  		}
>  	}
>  
> 
> 
> 


-- 
Nicolas Ferre