From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, KVM <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/6] KVM: MMU: abstract invalid guest pte mapping
Date: Mon, 22 Nov 2010 12:17:24 +0200 [thread overview]
Message-ID: <4CEA4334.5070106@redhat.com> (raw)
In-Reply-To: <4CEA436D.8050202@cn.fujitsu.com>
On 11/22/2010 12:18 PM, Xiao Guangrong wrote:
> >
> > I think the order is reversed. If !is_present_gpte(), it doesn't matter
> > if reserved bits are set or not.
> >
>
> if !is_present_gpte()&& is_rsvd_bits_set, then we may mark the spte notrap,
> so the guest will detect #PF with PFEC.P=PEFC.RSVD=0, but the appropriate PFEC
> is PFEC.P=0&& PEFC.RSVD=1 ?
I think the correct PFEC is .P = .RSVD = 0, but best to check on real
hardware to be sure.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-11-22 10:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 9:01 [PATCH v3 1/6] KVM: MMU: fix forgot flush tlbs on sync_page path Xiao Guangrong
2010-11-19 9:02 ` [PATCH v3 2/6] KVM: MMU: don't drop spte if overwrite it from W to RO Xiao Guangrong
2010-11-19 9:03 ` [PATCH v3 3/6] KVM: MMU: rename 'reset_host_protection' to 'host_writable' Xiao Guangrong
2010-11-19 9:04 ` [PATCH v3 4/6] KVM: MMU: remove 'clear_unsync' parameter Xiao Guangrong
2010-11-19 9:04 ` [PATCH v3 5/6] KVM: MMU: abstract invalid guest pte mapping Xiao Guangrong
2010-11-22 9:28 ` Avi Kivity
2010-11-22 10:18 ` Xiao Guangrong
2010-11-22 10:17 ` Avi Kivity [this message]
2010-11-23 3:08 ` Xiao Guangrong
2010-11-19 9:05 ` [PATCH v3 6/6] KVM: MMU: delay flush all tlbs on sync_page path Xiao Guangrong
2010-11-19 16:11 ` Marcelo Tosatti
2010-11-22 3:45 ` Xiao Guangrong
2010-11-22 14:19 ` Marcelo Tosatti
2010-11-22 21:46 ` Marcelo Tosatti
2010-11-23 3:13 ` Xiao Guangrong
2010-11-26 1:37 ` [PATCH v3 1/6] KVM: MMU: fix forgot flush " Xiao Guangrong
2010-11-26 14:29 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA4334.5070106@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).