Re: tvp5150 extension to tvp5151

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Hi Raffaele,

Em 19-11-2010 16:26, Raffaele Recalcati escreveu:
> I need to support fully tvp5151.
> So I'm trying to understand your driver, that is ready for VBI and not
> for video acquisition.
> I also take sometimes a look at tvp514x.c, for instance trying to add
> VIDIOC_ENUM_FMT and other ioctls.
> I think we can move from tvp5150.c to tvp515x.c, maybe...
> I don't think is good to have tvp51xx.c because tvp514x.c family is
> more complex (more inputs...).
> By now I'm using tvp5150.c with some modifications and video acquisition works.
> I need to complete the support in order to have gstreamer fully running.
> I'm working on 2.6.32, but I have planned to port it to mainline.

Renaming it to tvp515x.c and adding support for tvp5051 seems a good way.
With tvp5150, video acquisition works fine with several devices with em28xx,
although we may need to add more video formats at the media bus, depending
on what you're doing. I didn't test VBI support on it, because the devices
I have are based on em28xx, and I didn't find any way to capture the VBI
decoded packages and sent to userspace with that design. So, the basic stuff
is there, but maybe some adjusts may be needed for VBI.

> Do you have any suggestion for my work?

The better is to submit the patches you have, for us to apply upstream.

Cheers,
Mauro