[PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

Currently, Copyright and module description are not formal.


Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
---
 drivers/net/can/pch_can.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 5b7a392..3a39786 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -1,6 +1,6 @@
 /*
  * Copyright (C) 1999 - 2010 Intel Corporation.
- * Copyright (C) 2010 OKI SEMICONDUCTOR Co., LTD.
+ * Copyright (C) 2010 OKI SEMICONDUCTOR CO., LTD.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -1312,6 +1312,6 @@ static void __exit pch_can_pci_exit(void)
 }
 module_exit(pch_can_pci_exit);
 -MODULE_DESCRIPTION("Controller Area Network Driver");
+MODULE_DESCRIPTION("Intel EG20T PCH CAN(Controller Area Network) Driver");
 MODULE_LICENSE("GPL v2");
 MODULE_VERSION("0.94");
-- 
1.6.0.6

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

On 11/24/2010 08:36 AM, Tomoya MORINAGA wrote:
> Currently, Copyright and module description are not formal.
> 
> 
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
> ---
>  drivers/net/can/pch_can.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
> index 5b7a392..3a39786 100644
> --- a/drivers/net/can/pch_can.c
> +++ b/drivers/net/can/pch_can.c
> @@ -1,6 +1,6 @@
>  /*
>   * Copyright (C) 1999 - 2010 Intel Corporation.
> - * Copyright (C) 2010 OKI SEMICONDUCTOR Co., LTD.
> + * Copyright (C) 2010 OKI SEMICONDUCTOR CO., LTD.
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> @@ -1312,6 +1312,6 @@ static void __exit pch_can_pci_exit(void)
>  }
>  module_exit(pch_can_pci_exit);
>  -MODULE_DESCRIPTION("Controller Area Network Driver");
 ^^

Did your mailer spawn some extra spaces here? The header of your mail
tells me:
"User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.15)
Gecko/20101027 Thunderbird/3.0.10"
I strongly suggest to use git send-email.

> +MODULE_DESCRIPTION("Intel EG20T PCH CAN(Controller Area Network) Driver");
>  MODULE_LICENSE("GPL v2");
>  MODULE_VERSION("0.94");

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

On Wednesday, November 24, 2010 7:51 PM, Marc Kleine-Budde wrote:

> Did your mailer spawn some extra spaces here? The header of your mail
> tells me:
> "User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.15)
> Gecko/20101027 Thunderbird/3.0.10"
> I strongly suggest to use git send-email.

Sorry, we also want to use "git send-email".
However , in our network environment, it couldn't send patch using "git send-email " anyway.

According to kernel documentation, I have set thunderbird configuration with correctly.

>  module_exit(pch_can_pci_exit);
>  -MODULE_DESCRIPTION("Controller Area Network Driver");
>
You are right.
Confirming my tx mail box of thunderbird, I can see the invalid space.
I don't know the reason why.


---
Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

On Wednesday, November 24, 2010 7:51 PM, Marc Kleine-Budde wrote:
> Did your mailer spawn some extra spaces here?
Sorry for in convenience.
Once saving patch-mail temporary, it seems sometimes mail format is broken.
I can see the phonemenon.

I sent v3 patch series without temporary savings.

---
Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

On Wednesday, November 24, 2010 7:51 PM, Marc Kleine-Budde wrote:
> Did your mailer spawn some extra spaces here? The header of your mail
> tells me:
> "User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.15)
> Gecko/20101027 Thunderbird/3.0.10"
> I strongly suggest to use git send-email.

At last, I can use "git send-email".
However, I have faced issue.
In case single destination address is OK, but in case multiple address is 
set,
I can see the following error.

Relay access denied

I show my failure command.
git send-email --smtp-server xxx.com --smtp-server-port yyy --smtp-ssl -to 
aaa.com -to bbb.com -to ccc.com
 -cc ccc.com -cc ddd.com -cc eee.com -bcc fff.com -bcc ggg.com *.patch

Do you have any information about the issue ?

Thanks

/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_
Tomoya Morinaga
OKI SEMICONDUCTOR CO., LTD. 

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

On 12/07/2010 01:46 AM, Tomoya MORINAGA wrote:
> On Wednesday, November 24, 2010 7:51 PM, Marc Kleine-Budde wrote:
>> Did your mailer spawn some extra spaces here? The header of your mail
>> tells me:
>> "User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.15)
>> Gecko/20101027 Thunderbird/3.0.10"
>> I strongly suggest to use git send-email.
> 
> At last, I can use "git send-email".
> However, I have faced issue.
> In case single destination address is OK, but in case multiple address
> is set,
> I can see the following error.
> 
> Relay access denied
> 
> I show my failure command.
> git send-email --smtp-server xxx.com --smtp-server-port yyy --smtp-ssl
> -to aaa.com -to bbb.com -to ccc.com
> -cc ccc.com -cc ddd.com -cc eee.com -bcc fff.com -bcc ggg.com *.patch

According to my man page it's:

--cc=<address>
--to=<address>

> Do you have any information about the issue ?

Try the above parameter format, if it doesn't work talk to your IT guys.
Have the time stamp and involved addresses (to,cc,smtp-server) of a
working and not working git send-email attempt ready.

cheers, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

On Tuesday, December 07, 2010 5:02 PM, Marc Kleine-Budde wrote:

> According to my man page it's:

> --cc=<address>
> --to=<address>

As to the above, I had already done.
But, issue remains to be seen.

Thanks
/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_
Tomoya Morinaga
OKI SEMICONDUCTOR CO., LTD.

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

> In case single destination address is OK, but in case multiple address is 
> set,
> I can see the following error.
> Relay access denied

The above was not true.
It seems in case destination mail domain is external, (except 
"@okisemi.com"),
this error is occurred.
In fact, in case multiple address with internal domain,
it is success to send patch.

Our smtp server may have restriction of something.

It seems I must use mailer "thunderbird" again.

Thanks,

/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_
Tomoya Morinaga
OKI SEMICONDUCTOR CO., LTD. 

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Miguel Ojeda]

2010/12/7 Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>:
>> In case single destination address is OK, but in case multiple address is
>> set,
>> I can see the following error.
>> Relay access denied
>
> The above was not true.
> It seems in case destination mail domain is external, (except
> "@okisemi.com"),
> this error is occurred.
> In fact, in case multiple address with internal domain,
> it is success to send patch.
>
> Our smtp server may have restriction of something.
>
> It seems I must use mailer "thunderbird" again.

For me, Evolution worked fine (no line wrapping, etc.).

>
> Thanks,
>
> /_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_
> Tomoya Morinaga
> OKI SEMICONDUCTOR CO., LTD.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On 12/07/2010 10:50 AM, Tomoya MORINAGA wrote:
>> In case single destination address is OK, but in case multiple address
>> is set,
>> I can see the following error.
>> Relay access denied
> 
> The above was not true.
> It seems in case destination mail domain is external, (except
> "@okisemi.com"),
> this error is occurred.
> In fact, in case multiple address with internal domain,
> it is success to send patch.
> 
> Our smtp server may have restriction of something.
> 
> It seems I must use mailer "thunderbird" again.

How do you send mail with thunderbord, then? I suppose you use smtp
there, too.

cheers, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

On Tuesday, December 07, 2010 7:38 PM, Marc Kleine-Budde wrote:
> How do you send mail with thunderbord, then? I suppose you use smtp
> there, too.

Yes,
The same SMTP server is used when thunderbird, too.

Thanks,
/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_
Tomoya Morinaga
OKI SEMICONDUCTOR CO., LTD.

----- Original Message ----- 
From: "Marc Kleine-Budde" <mkl@pengutronix.de>
To: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>; 
<socketcan-core@lists.berlios.de>; <netdev@vger.kernel.org>; 
<linux-kernel@vger.kernel.org>; <qi.wang@intel.com>; 
<yong.y.wang@intel.com>; <andrew.chih.howe.khor@intel.com>; 
<joel.clark@intel.com>; <kok.howg.ewe@intel.com>; <margie.foster@intel.com>
Sent: Tuesday, December 07, 2010 7:38 PM
Subject: Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright 
and module description

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On 12/07/2010 11:56 AM, Tomoya MORINAGA wrote:
> On Tuesday, December 07, 2010 7:38 PM, Marc Kleine-Budde wrote:
>> How do you send mail with thunderbord, then? I suppose you use smtp
>> there, too.
> 
> Yes,
> The same SMTP server is used when thunderbird, too.

Then check your settings, e.g. username, ssmtp, TSL, port, passwd.

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

On Tuesday, December 07, 2010 8:02 PM, Marc Kleine-Budde wrote:
> Then check your settings, e.g. username, ssmtp, TSL, port, passwd.

By adding "--smtp-usr=xxx", I can send a patch to external domain.
Thank you.^_^

However, I sent v8 series by hand.
Next, I will use get-send-email command.

/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_
Tomoya Morinaga
OKI SEMICONDUCTOR CO., LTD.
----- Original Message ----- 
From: "Marc Kleine-Budde" <mkl@pengutronix.de>
To: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>; 
<socketcan-core@lists.berlios.de>; <netdev@vger.kernel.org>; 
<linux-kernel@vger.kernel.org>; <qi.wang@intel.com>; 
<yong.y.wang@intel.com>; <andrew.chih.howe.khor@intel.com>; 
<joel.clark@intel.com>; <kok.howg.ewe@intel.com>; <margie.foster@intel.com>
Sent: Tuesday, December 07, 2010 8:02 PM
Subject: Re: [PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright 
and module description

[PATCH net-next-2.6 8/17 v2] can: EG20T PCH: Change Copyright and module description

[Tomoya MORINAGA]

Currently, Copyright and module description are not formal.

Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
---
 drivers/net/can/pch_can.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 5b7a392..3a39786 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -1,6 +1,6 @@
 /*
  * Copyright (C) 1999 - 2010 Intel Corporation.
- * Copyright (C) 2010 OKI SEMICONDUCTOR Co., LTD.
+ * Copyright (C) 2010 OKI SEMICONDUCTOR CO., LTD.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -1312,6 +1312,6 @@ static void __exit pch_can_pci_exit(void)
 }
 module_exit(pch_can_pci_exit);
 
-MODULE_DESCRIPTION("Controller Area Network Driver");
+MODULE_DESCRIPTION("Intel EG20T PCH CAN(Controller Area Network) Driver");
 MODULE_LICENSE("GPL v2");
 MODULE_VERSION("0.94");
-- 
1.6.0.6