public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: michael@ellerman.id.au
Cc: LKML <linux-kernel@vger.kernel.org>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org,
	linux-mips <linux-mips@linux-mips.org>,
	microblaze-uclinux@itee.uq.edu.au,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: RFC: Mega rename of device tree routines from of_*() to dt_*()
Date: Wed, 24 Nov 2010 09:00:46 -0800	[thread overview]
Message-ID: <4CED44BE.1030405@caviumnetworks.com> (raw)
In-Reply-To: <1290607413.12457.44.camel@concordia>

On 11/24/2010 06:03 AM, Michael Ellerman wrote:
> Hi all,
>
> There were some murmurings on IRC last week about renaming the of_*()
> routines. I was procrastinating at the time and said I'd have a look at
> it, so here I am.
>
> The thinking is that on many platforms that use the of_() routines
> OpenFirmware is not involved at all, this is true even on many powerpc
> platforms. Also for folks who don't know the OpenFirmware connection it
> reads as "of", as in "a can of worms".
>
> Personally I'm a bit ambivalent about it, the OF name is a bit wrong so
> it would be nice to get rid of, but it's a lot of churn.
>
> So I'm hoping people with either say "YES this is a great idea", or "NO
> this is stupid".
>
> As step one I've just renamed as many routines as I could find to see
> what the resulting patch looks like, so we can quantify the churn. I
> also did device.of_node, which is used quite a bit.
>
> Thoughts?
>
> of ->  dt most places I could think of (done mechanically):
>
[...]
>   drivers/of/address.c                               |  114 ++++++------
>   drivers/of/base.c                                  |   14 +-
>   drivers/of/device.c                                |   36 ++--
>   drivers/of/fdt.c                                   |    4 +-
>   drivers/of/gpio.c                                  |   32 ++--
>   drivers/of/irq.c                                   |    4 +-
>   drivers/of/of_i2c.c                                |   18 +-
>   drivers/of/of_mdio.c                               |   16 +-
>   drivers/of/of_spi.c                                |   12 +-
>   drivers/of/pdt.c                                   |    4 +-
>   drivers/of/platform.c                              |  212 ++++++++++----------

Well, not that I care one way or the other, but for consistency you 
should change all these directory and file names as well.

David Daney


  parent reply	other threads:[~2010-11-24 17:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 14:03 RFC: Mega rename of device tree routines from of_*() to dt_*() Michael Ellerman
2010-11-24 15:44 ` Timur Tabi
2010-11-24 17:00 ` David Daney [this message]
2010-11-24 17:02 ` Stephen Neuendorffer
2010-11-24 17:18   ` David Daney
2010-11-24 18:02     ` Grant Likely
2010-11-24 18:32     ` Stephen Neuendorffer
2010-11-24 18:18 ` RFC: " David VomLehn
2010-11-25 13:34 ` Michael Ellerman
2010-11-25 14:01   ` Geert Uytterhoeven
2010-11-25 20:52     ` Benjamin Herrenschmidt
2010-11-25 16:17   ` Grant Likely
2010-11-26  3:15     ` Michael Ellerman
2010-11-26  4:42       ` Mitch Bradley
2010-11-26  5:50         ` Michael Ellerman
2010-11-26  7:15           ` Grant Likely
2010-11-26  7:36           ` Mitch Bradley
2010-11-29  5:55   ` David Gibson
2010-11-29  6:07     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CED44BE.1030405@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox