From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: andrew.chih.howe.khor@intel.com,
Samuel Ortiz <sameo@linux.intel.com>,
margie.foster@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, socketcan-core@lists.berlios.de,
yong.y.wang@intel.com, kok.howg.ewe@intel.com,
Wolfgang Grandegger <wg@grandegger.com>,
joel.clark@intel.com, "David S. Miller" <davem@davemloft.net>,
Christian Pellegrin <chripell@fsfe.org>,
qi.wang@intel.com
Subject: Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue
Date: Thu, 25 Nov 2010 12:47:44 +0100 [thread overview]
Message-ID: <4CEE4CE0.7050500@pengutronix.de> (raw)
In-Reply-To: <001c01cb8c91$6e93aef0$66f8800a@maildom.okisemi.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On 11/25/2010 12:10 PM, Tomoya MORINAGA wrote:
> On Wednesday, November 24, 2010 10:31 PM, Marc Kleine-Budde wrote :
>
>>> For easy to read, some sub-functions are created.
>>>
>>>
>>> Modify complex "goto" to do~while.
>> What about the next_flag in the rx_normal function? Can you get rid of
>> it, too?
> Subsequent Patch (11/17 Delete unnecessary ...) deletes "next_flag" in the rx_normal function.
Thanks, I've found the patch myself.
cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2010-11-25 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 12:17 [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue Tomoya MORINAGA
2010-11-24 13:31 ` Marc Kleine-Budde
2010-11-25 11:10 ` Tomoya MORINAGA
2010-11-25 11:47 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEE4CE0.7050500@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox