Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue

Tomoya MORINAGA
2010-11-25T11:10:59Z

On Wednesday, November 24, 2010 10:31 PM, Marc Kleine-Budde wrote :

>> For easy to read, some sub-functions are created.
>>
>>
>> Modify complex "goto" to do~while.
>What about the next_flag in the rx_normal function? Can you get rid of
>it, too?
Subsequent Patch (11/17 Delete unnecessary ...) deletes "next_flag" in the rx_normal function.

---
Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

----- Original Message -----
From: "Marc Kleine-Budde" <mkl@pengutronix.de>
To: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>; "Wolfram Sang" <w.sang@pengutronix.de>; "Christian Pellegrin"
<chripell@fsfe.org>; "Barry Song" <21cnbao@gmail.com>; "Samuel Ortiz" <sameo@linux.intel.com>;
<socketcan-core@lists.berlios.de>; <netdev@vger.kernel.org>; <linux-kernel@vger.kernel.org>; "David S. Miller"
<davem@davemloft.net>; <andrew.chih.howe.khor@intel.com>; <qi.wang@intel.com>; <margie.foster@intel.com>;
<yong.y.wang@intel.com>; <kok.howg.ewe@intel.com>; <joel.clark@intel.com>
Sent: Wednesday, November 24, 2010 10:31 PM
Subject: Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue