Re: [PATCH 2/2] ext4: Add EXT4_IOC_TRIM ioctl to handle batched discard

Ted Ts'o
2010-11-20T01:37:57Z

On Fri, Nov 19, 2010 at 05:26:51PM +0100, Lukas Czerner wrote:
> > If we're going to keep FITRIM defined in include/fs.h, then we should
> > just dispatch off of FITRIM below, and not define EXT4_IOC_TRIM.
> >
> > > + case EXT4_IOC_TRIM:
> > > + {
> >
> > Agreed?
>
> I am ok either way, I was just following example of EXT4_IOC_GETFLAGS ->
> FS_IOC_GETFLAGS etc..

The history of that was the ioctl was originally EXT4_IOC_GETFLAGS and
it was later generalized to be FS_IOC_GETFLAGS. In this case though
we started with it being an generalized interface, so there's no need
to create an EXT4_IOC_TRIM ioctl. I'll fix that up in your patch when
I add it to the ext4 patch queue.

- Ted