From: Avi Kivity <avi@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-users@vger.kernel.org
Subject: Re: [PATCH] Don't spam trace report about missing fields
Date: Mon, 29 Nov 2010 19:22:05 +0200 [thread overview]
Message-ID: <4CF3E13D.7040204@redhat.com> (raw)
In-Reply-To: <1291048005.30543.731.camel@gandalf.stny.rr.com>
On 11/29/2010 06:26 PM, Steven Rostedt wrote:
> On Mon, 2010-11-29 at 18:20 +0200, Avi Kivity wrote:
> > Instead of spamming the output with complaints about missing fields, simply
> > return an error to the caller, which can print something out or do something
> > more intelligent about them.
> >
> > Fixes kvm plugin tracing older kernels.
>
> Hmm, what about just passing in err=0?
I was just patching the printk out it mindlessly. Will send a new patch.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-11-29 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 16:20 [PATCH] Don't spam trace report about missing fields Avi Kivity
2010-11-29 16:26 ` Steven Rostedt
2010-11-29 17:22 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF3E13D.7040204@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox