public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "R.M. Thomas" <rmthomas@sciolus.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: easycap: fix build failure
Date: Mon, 29 Nov 2010 18:42:22 +0000	[thread overview]
Message-ID: <4CF3F40E.3040508@sciolus.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1011291813060.981@pobox.suse.cz>

Jiri Kosina wrote:
> Now, I really believe that this driver is completely hopeless and the only 
> option is complete from-scratch rewrite. I have been looking into it for 
> approximately ~30 seconds (solely to fix this build failure), and I really 
> don't know what to say.

You are quite right of course.  This driver does indeed require a complete
re-write.  The non-standard formatting and (now) redundant debugging macros
are actually the least troublesome issues.  More significant is the need to
replace most of the routines by existing functions from the V4L subsystem.
Unfortunately I shall be unable to undertake this essential work myself in
the foreseeable future owing to other commitments.  Probably the simplest
solution would be to drop the driver from staging.

Even in its present untidy state the driver does work reasonably well on x86
and x86-64, so something could possibly be salvaged from it.

Mike   


      reply	other threads:[~2010-11-29 18:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29 17:22 [PATCH] staging: easycap: fix build failure Jiri Kosina
2010-11-29 18:42 ` R.M. Thomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF3F40E.3040508@sciolus.org \
    --to=rmthomas@sciolus.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox