From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221Ab0K2Sm3 (ORCPT ); Mon, 29 Nov 2010 13:42:29 -0500 Received: from claranet-outbound-smtp04.uk.clara.net ([195.8.89.37]:55816 "EHLO claranet-outbound-smtp04.uk.clara.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233Ab0K2Sm2 (ORCPT ); Mon, 29 Nov 2010 13:42:28 -0500 Message-ID: <4CF3F40E.3040508@sciolus.org> Date: Mon, 29 Nov 2010 18:42:22 +0000 From: "R.M. Thomas" User-Agent: Mozilla-Thunderbird 2.0.0.24 (X11/20100329) MIME-Version: 1.0 To: Jiri Kosina CC: Greg Kroah-Hartman , Michal Marek , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: easycap: fix build failure References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Kosina wrote: > Now, I really believe that this driver is completely hopeless and the only > option is complete from-scratch rewrite. I have been looking into it for > approximately ~30 seconds (solely to fix this build failure), and I really > don't know what to say. You are quite right of course. This driver does indeed require a complete re-write. The non-standard formatting and (now) redundant debugging macros are actually the least troublesome issues. More significant is the need to replace most of the routines by existing functions from the V4L subsystem. Unfortunately I shall be unable to undertake this essential work myself in the foreseeable future owing to other commitments. Probably the simplest solution would be to drop the driver from staging. Even in its present untidy state the driver does work reasonably well on x86 and x86-64, so something could possibly be salvaged from it. Mike