From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
suresh.b.siddha@intel.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, indou.takao@jp.fujitsu.com
Subject: [PATCH 1/2] dmar: fix fault interrupt setup
Date: Tue, 30 Nov 2010 17:30:32 +0900 [thread overview]
Message-ID: <4CF4B628.7060903@jp.fujitsu.com> (raw)
In-Reply-To: <4CF4B597.4030708@jp.fujitsu.com>
Fix the problem dmar fault event is not notified in x2apic cluster mode.
In the current code, dmar fault event is configured before setting up
the x86_cpu_to_logical_apicid percpu variable in x2apic cluster
mode. Because of this, invalid apic ID is used for dmar fault
interrupt and this cuases the problem.
To fix the problem, do dmar fault event configuration after local apic
setup (after end_local_APIC_setup()).
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 9 +++++++++
arch/x86/kernel/apic/probe_64.c | 7 -------
2 files changed, 9 insertions(+), 7 deletions(-)
Index: linux-next-20101125/arch/x86/kernel/apic/apic.c
===================================================================
--- linux-next-20101125.orig/arch/x86/kernel/apic/apic.c
+++ linux-next-20101125/arch/x86/kernel/apic/apic.c
@@ -1745,6 +1745,15 @@ int __init APIC_init_uniprocessor(void)
end_local_APIC_setup();
+#ifdef CONFIG_INTR_REMAP
+ /*
+ * Now that local APIC setup is completed, configure the fault
+ * handling for interrupt remapping.
+ */
+ if (intr_remapping_enabled)
+ enable_drhd_fault_handling();
+#endif
+
#ifdef CONFIG_X86_IO_APIC
if (smp_found_config && !skip_ioapic_setup && nr_ioapics)
setup_IO_APIC();
Index: linux-next-20101125/arch/x86/kernel/apic/probe_64.c
===================================================================
--- linux-next-20101125.orig/arch/x86/kernel/apic/probe_64.c
+++ linux-next-20101125/arch/x86/kernel/apic/probe_64.c
@@ -79,13 +79,6 @@ void __init default_setup_apic_routing(v
/* need to update phys_pkg_id */
apic->phys_pkg_id = apicid_phys_pkg_id;
}
-
- /*
- * Now that apic routing model is selected, configure the
- * fault handling for intr remapping.
- */
- if (intr_remapping_enabled)
- enable_drhd_fault_handling();
}
/* Same for both flat and physical. */
next prev parent reply other threads:[~2010-11-30 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 8:28 [PATCH 0/2] Fix dmar fault interrupt problems Kenji Kaneshige
2010-11-30 8:30 ` Kenji Kaneshige [this message]
2010-11-30 20:18 ` [PATCH 1/2] dmar: fix fault interrupt setup Suresh Siddha
2010-12-01 5:13 ` Kenji Kaneshige
2010-11-30 8:32 ` [PATCH 2/2] dmar: Fix dmar interrupt affinity handling Kenji Kaneshige
2010-11-30 18:09 ` [PATCH 0/2] Fix dmar fault interrupt problems Suresh Siddha
2010-11-30 18:13 ` Chris Wright
2010-11-30 18:20 ` Suresh Siddha
2010-11-30 19:28 ` Chris Wright
2010-11-30 19:52 ` Suresh Siddha
2010-11-30 22:20 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF4B628.7060903@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).