From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Chethan Krishna N <chethan.krishna@stericsson.com>,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
preetham.rao@stericsson.com, lm-sensors@lm-sensors.org,
mian-yousaf.kaukab@linaro.org, Dmitry Torokhov <dtor@mail.ru>
Subject: Re: [lm-sensors] [PATCH] lsm303dlh: Adding Accelerometer and Magnetometer support
Date: Wed, 01 Dec 2010 10:32:43 +0000 [thread overview]
Message-ID: <4CF6244B.9050703@cam.ac.uk> (raw)
In-Reply-To: <20101201100016.22b3ea0d@endymion.delvare>
On 12/01/10 09:00, Jean Delvare wrote:
> On Wed, 1 Dec 2010 10:44:07 +0530, Chethan Krishna N wrote:
>> From: Chethan Krishna N <chethan.krishna@stericsson.com>
>>
>> lsm303dlh accelerometer magnetometer device support added.
>> Also provides input device support through interrupts.
>>
>> Signed-off-by: Chethan Krishna N <chethan.krishna@stericsson.com>
>> ---
>> drivers/hwmon/Kconfig | 23 +
>> drivers/hwmon/Makefile | 1 +
>> drivers/hwmon/lsm303dlh_a.c | 1112 +++++++++++++++++++++++++++++++++++++++++++
>> drivers/hwmon/lsm303dlh_m.c | 764 +++++++++++++++++++++++++++++
>> include/linux/lsm303dlh.h | 56 +++
>> 5 files changed, 1956 insertions(+), 0 deletions(-)
>> mode change 100644 => 100755 drivers/hwmon/Kconfig
>> create mode 100644 drivers/hwmon/lsm303dlh_a.c
>> create mode 100644 drivers/hwmon/lsm303dlh_m.c
>> create mode 100644 include/linux/lsm303dlh.h
>
> Nack. This isn't a hardware monitoring driver, so it has nothing to do
> in drivers/hwmon. Please find a better place.
>
Current options are:
* persuade Dmitry it is primarily a human input device and go for drivers/input
* drivers/misc
* drivers/staging/iio (couple of magnetometers and more general IMU's in there
already, but then if you primary use is input, the input bridge is only at proof
of concept stage at the moment).
Take your pick.
Where ever it physically gets located, the abi needs to ideally match existing
ones (particularly all those sysfs attributes).
If you want to change things in existing abi's then feel free to propose doing
so. What won't be acceptable anywhere in mainline is to add completely
different ones when existing options are in use in other drivers (without
a very good reason and explanation.)
Jonathan
cc'd Dmitry (who, as input maintainer should have been cc'd on original email)
next prev parent reply other threads:[~2010-12-01 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 5:14 [PATCH] lsm303dlh: Adding Accelerometer and Magnetometer support Chethan Krishna N
2010-12-01 9:00 ` Jean Delvare
2010-12-01 10:32 ` Jonathan Cameron [this message]
2010-12-01 11:28 ` [lm-sensors] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF6244B.9050703@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=chethan.krishna@stericsson.com \
--cc=dtor@mail.ru \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mian-yousaf.kaukab@linaro.org \
--cc=preetham.rao@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox