Re: [PATCH 3/3] ideapad: add hotkey support

[Ike Panhc <ike.pan@canonical.com>]

On 12/03/2010 07:41 AM, Dave Hansen wrote:
> On Wed, 2010-11-17 at 15:00 +0800, Ike Panhc wrote:
>> +static void ideapad_input_report(unsigned long scancode)
>> +{
>> +       sparse_keymap_report_event(ideapad_priv->inputdev, scancode, 1, true);
>> +} 
> 
> I got a little build error about some unresolved symbols in the module
> while compiling:
>         
>         ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined!
>         ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined!
>         ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined!
>         
> You can get it to go away by setting CONFIG_INPUT_SPARSEKMAP=m or =y
> in .config.  But, I think your patches need this:
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index faec777..879d266 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -226,6 +226,7 @@ config IDEAPAD_LAPTOP
>  	tristate "Lenovo IdeaPad Laptop Extras"
>  	depends on ACPI
>  	depends on RFKILL
> +	select INPUT_SPARSEKMAP
>  	help
>  	  This is a driver for the rfkill switches on Lenovo IdeaPad netbooks.
>  
> 
> Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
> 

Thanks, you are right