Re: [PATCH -tip 7/7] perf bts trace: add print all option

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2010/12/03 13:00), Akihiro Nagai wrote:
> For ease of use, add option printing all information '-A' or '--all'.
> This option can print following information.
>   - pid
>   - command name
>   - address
>   - function+offset
>   - elf file path
> 
> Signed-off-by: Akihiro Nagai <akihiro.nagai.hw@hitachi.com>

Looks good to me :)

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Cc: linux-kernel@vger.kernel.org
> ---
> 
>  tools/perf/Documentation/perf-bts.txt |    3 +++
>  tools/perf/builtin-bts.c              |    6 ++++++
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-bts.txt b/tools/perf/Documentation/perf-bts.txt
> index 13ee862..c598dd2 100644
> --- a/tools/perf/Documentation/perf-bts.txt
> +++ b/tools/perf/Documentation/perf-bts.txt
> @@ -44,6 +44,9 @@ OPTIONS
>  -s::
>  --symbol::
>  	Print function name and offset. (default)
> +-A::
> +--all::
> +	Print all information.
>  
>  SEE ALSO
>  --------
> diff --git a/tools/perf/builtin-bts.c b/tools/perf/builtin-bts.c
> index 71c7fbe..c359f70 100644
> --- a/tools/perf/builtin-bts.c
> +++ b/tools/perf/builtin-bts.c
> @@ -34,6 +34,9 @@ struct exec_info {
>  #define EI_FLAG_PRINT_ELFPATH		(1 << 3)
>  #define EI_FLAG_PRINT_SYMBOL		(1 << 4)
>  
> +/* all print flags are enabled */
> +#define	 EI_FLAG_PRINT_ALL		-1UL
> +
>  /* it's used when no print item specified */
>  #define EI_FLAG_PRINT_DEFAULT		EI_FLAG_PRINT_SYMBOL
>  
> @@ -92,6 +95,9 @@ static const struct option bts_options[] = {
>  				   "print function+offset (default)",
>  				   set_print_flags,
>  				   (void *)EI_FLAG_PRINT_SYMBOL),
> +	OPT_CALLBACK_DEFAULT_NOOPT('A', "all", NULL, NULL,
> +				   "print all items", set_print_flags,
> +				   (void *)EI_FLAG_PRINT_ALL),
>  	OPT_END()
>  };
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com