From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: SVM: Add xsetbv intercept
Date: Mon, 06 Dec 2010 18:10:46 +0200 [thread overview]
Message-ID: <4CFD0B06.9010308@redhat.com> (raw)
In-Reply-To: <1291394523-7689-1-git-send-email-joerg.roedel@amd.com>
On 12/03/2010 06:42 PM, Joerg Roedel wrote:
> This patch implements the xsetbv intercept to the AMD part
> of KVM. This makes AVX usable in a save way for the guest on
> AVX capable AMD hardware.
> The patch is tested by using AVX in the guest and host in
> parallel and checking for data corruption. I also used the
> KVM xsave unit-tests and they all pass.
>
That is really strange. You didn't need to do anything to get cpuid.avx
recognized. So running an older kvm on newer hardware will happily
expose avx even though it's not supported.
We screwed up - we should have made cpuid.avx dependent on vendor support.
The patch itself looks fine, I just want to understand this point first.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-06 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 16:42 [PATCH] KVM: SVM: Add xsetbv intercept Joerg Roedel
2010-12-06 16:10 ` Avi Kivity [this message]
2010-12-06 17:48 ` Roedel, Joerg
2010-12-07 9:34 ` Avi Kivity
2010-12-07 16:12 ` Roedel, Joerg
2010-12-07 16:15 ` [PATCH 1/2] KVM: SVM: Do not report xsave in supported cpuid Joerg Roedel
2010-12-07 16:15 ` [PATCH 2/2] KVM: SVM: Add xsetbv intercept Joerg Roedel
2010-12-08 10:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFD0B06.9010308@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).