* resource map sanity check conflict
@ 2010-11-24 13:36 Jiri Slaby
2010-11-24 19:22 ` Bjorn Helgaas
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Slaby @ 2010-11-24 13:36 UTC (permalink / raw)
To: bjorn.helgaas; +Cc: David Airlie, LKML, abelay, Chris Wilson
Hi,
with 2.6.37-rc2 with some unrelated patches the following WARNING is
generated:
pnp 00:0a: [mem 0xfed40000-0xfed44fff]
pnp 00:0a: Plug and Play ACPI device, IDs ATM1200 PNP0c31 (active)
...
resource map sanity check conflict: 0xfed40000 0xfed44fff 0xfed44000
0xfed44fff Intel Flush Page
------------[ cut here ]------------
WARNING: at arch/x86/mm/ioremap.c:98 __ioremap_caller+0x353/0x380()
Hardware name: 766929G
Info: mapping multiple BARs. Your kernel is fine.
Modules linked in: snd tpm_tis(+) snd_page_alloc e1000e(+) rfkill pcspkr
iTCO_wdt soundcore yenta_socket pcmcia_rsrc pcmcia_core
iTCO_vendor_support battery sg tpm tpm_bios ac i915 drm_kms_helper drm
i2c_algo_bit button video ext4 crc16 jbd2 fan processor ata_generic
thermal thermal_sys
Pid: 382, comm: modprobe Not tainted 2.6.37-rc2-0.0.0.4ae942e-desktop #1
Call Trace:
[<ffffffff81005ac9>] dump_trace+0x79/0x340
[<ffffffff8151e921>] dump_stack+0x69/0x6f
[<ffffffff81057d2b>] warn_slowpath_common+0x7b/0xc0
[<ffffffff81057e25>] warn_slowpath_fmt+0x45/0x50
[<ffffffff81032453>] __ioremap_caller+0x353/0x380
[<ffffffffa02c68d7>] tpm_tis_init+0x57/0x660 [tpm_tis]
[<ffffffff812e8f29>] pnp_device_probe+0x69/0xe0
[<ffffffff8132afc4>] really_probe+0x64/0x200
[<ffffffff8132b343>] driver_probe_device+0x43/0xa0
[<ffffffff8132b433>] __driver_attach+0x93/0xa0
[<ffffffff8132a02e>] bus_for_each_dev+0x4e/0x80
[<ffffffff8132a978>] bus_add_driver+0x148/0x2f0
[<ffffffff8132b68a>] driver_register+0x6a/0x130
[<ffffffff810002da>] do_one_initcall+0x3a/0x170
[<ffffffff8109629a>] sys_init_module+0xba/0x210
[<ffffffff8100307b>] system_call_fastpath+0x16/0x1b
[<00007f5b8a330eda>] 0x7f5b8a330eda
---[ end trace 1409850b53f9aab2 ]---
tpm_tis 00:0a: 1.2 TPM (device-id 0x3203, rev-id 9)
/proc/iomem:
fed1c000-fed8ffff : reserved
fed1c000-fed1ffff : pnp 00:02
fed40000-fed4bfff : PCI Bus 0000:00
fed44000-fed44fff : Intel Flush Page
fed45000-fed4bfff : pnp 00:02
Is it a result of the past resource handling rewrote?
It seems like pci_bus_alloc_resource in
intel_alloc_chipset_flush_resource chooses a weird place to put the
mapping in.
dmesg:
https://bugzillafiles.novell.org/attachment.cgi?id=401414
lspci -vvnnxxx:
https://bugzillafiles.novell.org/attachment.cgi?id=401643
/proc/iomem:
https://bugzillafiles.novell.org/attachment.cgi?id=401476
regards,
--
js
suse labs
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: resource map sanity check conflict
2010-11-24 13:36 resource map sanity check conflict Jiri Slaby
@ 2010-11-24 19:22 ` Bjorn Helgaas
2010-12-06 20:17 ` Jiri Slaby
0 siblings, 1 reply; 7+ messages in thread
From: Bjorn Helgaas @ 2010-11-24 19:22 UTC (permalink / raw)
To: Jiri Slaby; +Cc: David Airlie, LKML, abelay, Chris Wilson, Thomas Renninger
On Wednesday, November 24, 2010 06:36:01 am Jiri Slaby wrote:
> Hi,
>
> with 2.6.37-rc2 with some unrelated patches the following WARNING is
> generated:
>
> pnp 00:0a: [mem 0xfed40000-0xfed44fff]
> pnp 00:0a: Plug and Play ACPI device, IDs ATM1200 PNP0c31 (active)
> ...
> resource map sanity check conflict: 0xfed40000 0xfed44fff 0xfed44000
> 0xfed44fff Intel Flush Page
> ------------[ cut here ]------------
> WARNING: at arch/x86/mm/ioremap.c:98 __ioremap_caller+0x353/0x380()
> ...
> /proc/iomem:
> fed1c000-fed8ffff : reserved
> fed1c000-fed1ffff : pnp 00:02
> fed40000-fed4bfff : PCI Bus 0000:00
> fed44000-fed44fff : Intel Flush Page
> fed45000-fed4bfff : pnp 00:02
>
>
> Is it a result of the past resource handling rewrote?
>
> It seems like pci_bus_alloc_resource in
> intel_alloc_chipset_flush_resource chooses a weird place to put the
> mapping in.
Yes, this is related to the PCI resource changes I made recently.
We used to allocate PCI resources from low addresses first and work
upwards, and now we do the reverse. So in 2.6.36, the "Intel Flush
Page" was probably allocated low in the [mem 0x7e000000-0xfebfffff]
window, but now we put it in the [mem 0xfed40000-0xfed4bfff] window:
pci_root PNP0A08:00: host bridge window [mem 0x000dc000-0x000dffff]
pci_root PNP0A08:00: host bridge window [mem 0xfed40000-0xfed4bfff]
I think the problem is that we ignore most of what ACPI tells us
about motherboard device resource usage. We do have the "system"
driver, which reserves resources used by PNP0c01 and PNP0c02 devices,
but we don't do anything about other devices like the ATM1200/PNP0c31
device which, in your case, is using some of the space in that
[mem 0xfed40000-0xfed4bfff] host bridge window.
I've been worried that this would bite us eventually, and I tried to
reserve all the ACPI resources in the PNP core a couple years ago,
but we had to revert that because it caused other problems. I still
think it's something we need to do after we straighten out the issues.
> dmesg:
> https://bugzillafiles.novell.org/attachment.cgi?id=401414
> lspci -vvnnxxx:
> https://bugzillafiles.novell.org/attachment.cgi?id=401643
> /proc/iomem:
> https://bugzillafiles.novell.org/attachment.cgi?id=401476
Is there a kernel.org bugzilla about this? If not, could you open one
and assign it to me?
Does your system still work, despite the warning? It can't be good
that we put the flush page on top of the TPM device, but I don't know
what intel-gtt actually *does* with the flush page.
Thanks,
Bjorn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: resource map sanity check conflict
2010-11-24 19:22 ` Bjorn Helgaas
@ 2010-12-06 20:17 ` Jiri Slaby
2010-12-06 20:34 ` Bjorn Helgaas
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Slaby @ 2010-12-06 20:17 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: David Airlie, LKML, abelay, Chris Wilson, Thomas Renninger
On 11/24/2010 08:22 PM, Bjorn Helgaas wrote:
> On Wednesday, November 24, 2010 06:36:01 am Jiri Slaby wrote:
>> Hi,
>>
>> with 2.6.37-rc2 with some unrelated patches the following WARNING is
>> generated:
>>
>> pnp 00:0a: [mem 0xfed40000-0xfed44fff]
>> pnp 00:0a: Plug and Play ACPI device, IDs ATM1200 PNP0c31 (active)
>> ...
>> resource map sanity check conflict: 0xfed40000 0xfed44fff 0xfed44000
>> 0xfed44fff Intel Flush Page
>> ------------[ cut here ]------------
>> WARNING: at arch/x86/mm/ioremap.c:98 __ioremap_caller+0x353/0x380()
>> ...
>
>> /proc/iomem:
>> fed1c000-fed8ffff : reserved
>> fed1c000-fed1ffff : pnp 00:02
>> fed40000-fed4bfff : PCI Bus 0000:00
>> fed44000-fed44fff : Intel Flush Page
>> fed45000-fed4bfff : pnp 00:02
>>
>>
>> Is it a result of the past resource handling rewrote?
>>
>> It seems like pci_bus_alloc_resource in
>> intel_alloc_chipset_flush_resource chooses a weird place to put the
>> mapping in.
>
> Yes, this is related to the PCI resource changes I made recently.
> We used to allocate PCI resources from low addresses first and work
> upwards, and now we do the reverse. So in 2.6.36, the "Intel Flush
> Page" was probably allocated low in the [mem 0x7e000000-0xfebfffff]
> window, but now we put it in the [mem 0xfed40000-0xfed4bfff] window:
>
> pci_root PNP0A08:00: host bridge window [mem 0x000dc000-0x000dffff]
> pci_root PNP0A08:00: host bridge window [mem 0xfed40000-0xfed4bfff]
>
> I think the problem is that we ignore most of what ACPI tells us
> about motherboard device resource usage. We do have the "system"
> driver, which reserves resources used by PNP0c01 and PNP0c02 devices,
> but we don't do anything about other devices like the ATM1200/PNP0c31
> device which, in your case, is using some of the space in that
> [mem 0xfed40000-0xfed4bfff] host bridge window.
>
> I've been worried that this would bite us eventually, and I tried to
> reserve all the ACPI resources in the PNP core a couple years ago,
> but we had to revert that because it caused other problems. I still
> think it's something we need to do after we straighten out the issues.
>
>> dmesg:
>> https://bugzillafiles.novell.org/attachment.cgi?id=401414
>> lspci -vvnnxxx:
>> https://bugzillafiles.novell.org/attachment.cgi?id=401643
>> /proc/iomem:
>> https://bugzillafiles.novell.org/attachment.cgi?id=401476
>
> Is there a kernel.org bugzilla about this? If not, could you open one
> and assign it to me?
I created the bko entry some time ago:
https://bugzilla.kernel.org/show_bug.cgi?id=23802
Any chance you will take a look?
> Does your system still work, despite the warning? It can't be good
> that we put the flush page on top of the TPM device, but I don't know
> what intel-gtt actually *does* with the flush page.
I think there is no problem other than the warning. I might ask the
reporter if you want to know for sure.
thanks,
--
js
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: resource map sanity check conflict
2010-12-06 20:17 ` Jiri Slaby
@ 2010-12-06 20:34 ` Bjorn Helgaas
2010-12-08 19:56 ` Bjorn Helgaas
0 siblings, 1 reply; 7+ messages in thread
From: Bjorn Helgaas @ 2010-12-06 20:34 UTC (permalink / raw)
To: Jiri Slaby; +Cc: David Airlie, LKML, abelay, Chris Wilson, Thomas Renninger
On Monday, December 06, 2010 01:17:33 pm Jiri Slaby wrote:
> On 11/24/2010 08:22 PM, Bjorn Helgaas wrote:
> > On Wednesday, November 24, 2010 06:36:01 am Jiri Slaby wrote:
> >> Hi,
> >>
> >> with 2.6.37-rc2 with some unrelated patches the following WARNING is
> >> generated:
> >>
> >> pnp 00:0a: [mem 0xfed40000-0xfed44fff]
> >> pnp 00:0a: Plug and Play ACPI device, IDs ATM1200 PNP0c31 (active)
> >> ...
> >> resource map sanity check conflict: 0xfed40000 0xfed44fff 0xfed44000
> >> 0xfed44fff Intel Flush Page
> >> ------------[ cut here ]------------
> >> WARNING: at arch/x86/mm/ioremap.c:98 __ioremap_caller+0x353/0x380()
> >> ...
> >
> >> /proc/iomem:
> >> fed1c000-fed8ffff : reserved
> >> fed1c000-fed1ffff : pnp 00:02
> >> fed40000-fed4bfff : PCI Bus 0000:00
> >> fed44000-fed44fff : Intel Flush Page
> >> fed45000-fed4bfff : pnp 00:02
> >>
> >>
> >> Is it a result of the past resource handling rewrote?
> >>
> >> It seems like pci_bus_alloc_resource in
> >> intel_alloc_chipset_flush_resource chooses a weird place to put the
> >> mapping in.
> >
> > Yes, this is related to the PCI resource changes I made recently.
> > We used to allocate PCI resources from low addresses first and work
> > upwards, and now we do the reverse. So in 2.6.36, the "Intel Flush
> > Page" was probably allocated low in the [mem 0x7e000000-0xfebfffff]
> > window, but now we put it in the [mem 0xfed40000-0xfed4bfff] window:
> >
> > pci_root PNP0A08:00: host bridge window [mem 0x000dc000-0x000dffff]
> > pci_root PNP0A08:00: host bridge window [mem 0xfed40000-0xfed4bfff]
> >
> > I think the problem is that we ignore most of what ACPI tells us
> > about motherboard device resource usage. We do have the "system"
> > driver, which reserves resources used by PNP0c01 and PNP0c02 devices,
> > but we don't do anything about other devices like the ATM1200/PNP0c31
> > device which, in your case, is using some of the space in that
> > [mem 0xfed40000-0xfed4bfff] host bridge window.
> >
> > I've been worried that this would bite us eventually, and I tried to
> > reserve all the ACPI resources in the PNP core a couple years ago,
> > but we had to revert that because it caused other problems. I still
> > think it's something we need to do after we straighten out the issues.
> >
> >> dmesg:
> >> https://bugzillafiles.novell.org/attachment.cgi?id=401414
> >> lspci -vvnnxxx:
> >> https://bugzillafiles.novell.org/attachment.cgi?id=401643
> >> /proc/iomem:
> >> https://bugzillafiles.novell.org/attachment.cgi?id=401476
> >
> > Is there a kernel.org bugzilla about this? If not, could you open one
> > and assign it to me?
>
> I created the bko entry some time ago:
> https://bugzilla.kernel.org/show_bug.cgi?id=23802
>
> Any chance you will take a look?
I will take a look, and in fact, I'm working on these:
https://bugzilla.kernel.org/show_bug.cgi?id=23542
https://bugzilla.kernel.org/show_bug.cgi?id=23332
and the fix I'm contemplating should also apply to 23802.
Bjorn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: resource map sanity check conflict
2010-12-06 20:34 ` Bjorn Helgaas
@ 2010-12-08 19:56 ` Bjorn Helgaas
2010-12-13 10:02 ` Jiri Slaby
0 siblings, 1 reply; 7+ messages in thread
From: Bjorn Helgaas @ 2010-12-08 19:56 UTC (permalink / raw)
To: Jiri Slaby; +Cc: David Airlie, LKML, abelay, Chris Wilson, Thomas Renninger
On Monday, December 06, 2010 01:34:56 pm Bjorn Helgaas wrote:
> On Monday, December 06, 2010 01:17:33 pm Jiri Slaby wrote:
> > On 11/24/2010 08:22 PM, Bjorn Helgaas wrote:
> > > On Wednesday, November 24, 2010 06:36:01 am Jiri Slaby wrote:
...
> > >> pnp 00:0a: [mem 0xfed40000-0xfed44fff]
> > >> pnp 00:0a: Plug and Play ACPI device, IDs ATM1200 PNP0c31 (active)
> > >> ...
> > >> resource map sanity check conflict: 0xfed40000 0xfed44fff 0xfed44000
...
> > > Yes, this is related to the PCI resource changes I made recently.
> > > We used to allocate PCI resources from low addresses first and work
> > > upwards, and now we do the reverse. So in 2.6.36, the "Intel Flush
> > > Page" was probably allocated low in the [mem 0x7e000000-0xfebfffff]
> > > window, but now we put it in the [mem 0xfed40000-0xfed4bfff] window:
> > >
> > > pci_root PNP0A08:00: host bridge window [mem 0x000dc000-0x000dffff]
> > > pci_root PNP0A08:00: host bridge window [mem 0xfed40000-0xfed4bfff]
> > >
> > > I think the problem is that we ignore most of what ACPI tells us
> > > about motherboard device resource usage. We do have the "system"
> > > driver, which reserves resources used by PNP0c01 and PNP0c02 devices,
> > > but we don't do anything about other devices like the ATM1200/PNP0c31
> > > device which, in your case, is using some of the space in that
> > > [mem 0xfed40000-0xfed4bfff] host bridge window.
> > I created the bko entry some time ago:
> > https://bugzilla.kernel.org/show_bug.cgi?id=23802
I have a patch here for testing:
https://bugzilla.kernel.org/attachment.cgi?id=39262
Bjorn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: resource map sanity check conflict
2010-12-08 19:56 ` Bjorn Helgaas
@ 2010-12-13 10:02 ` Jiri Slaby
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Slaby @ 2010-12-13 10:02 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: David Airlie, LKML, abelay, Chris Wilson, Thomas Renninger
On 12/08/2010 08:56 PM, Bjorn Helgaas wrote:
> On Monday, December 06, 2010 01:34:56 pm Bjorn Helgaas wrote:
>> On Monday, December 06, 2010 01:17:33 pm Jiri Slaby wrote:
>>> On 11/24/2010 08:22 PM, Bjorn Helgaas wrote:
>>>> On Wednesday, November 24, 2010 06:36:01 am Jiri Slaby wrote:
> ...
>>>>> pnp 00:0a: [mem 0xfed40000-0xfed44fff]
>>>>> pnp 00:0a: Plug and Play ACPI device, IDs ATM1200 PNP0c31 (active)
>>>>> ...
>>>>> resource map sanity check conflict: 0xfed40000 0xfed44fff 0xfed44000
> ...
>>>> Yes, this is related to the PCI resource changes I made recently.
>>>> We used to allocate PCI resources from low addresses first and work
>>>> upwards, and now we do the reverse. So in 2.6.36, the "Intel Flush
>>>> Page" was probably allocated low in the [mem 0x7e000000-0xfebfffff]
>>>> window, but now we put it in the [mem 0xfed40000-0xfed4bfff] window:
>>>>
>>>> pci_root PNP0A08:00: host bridge window [mem 0x000dc000-0x000dffff]
>>>> pci_root PNP0A08:00: host bridge window [mem 0xfed40000-0xfed4bfff]
>>>>
>>>> I think the problem is that we ignore most of what ACPI tells us
>>>> about motherboard device resource usage. We do have the "system"
>>>> driver, which reserves resources used by PNP0c01 and PNP0c02 devices,
>>>> but we don't do anything about other devices like the ATM1200/PNP0c31
>>>> device which, in your case, is using some of the space in that
>>>> [mem 0xfed40000-0xfed4bfff] host bridge window.
>
>>> I created the bko entry some time ago:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=23802
>
> I have a patch here for testing:
>
> https://bugzilla.kernel.org/attachment.cgi?id=39262
Yes, it works:
https://bugzillafiles.novell.org/attachment.cgi?id=404327
thanks,
--
js
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <fSnJM-6IJ-11@gated-at.bofh.it>]
end of thread, other threads:[~2010-12-13 10:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-24 13:36 resource map sanity check conflict Jiri Slaby
2010-11-24 19:22 ` Bjorn Helgaas
2010-12-06 20:17 ` Jiri Slaby
2010-12-06 20:34 ` Bjorn Helgaas
2010-12-08 19:56 ` Bjorn Helgaas
2010-12-13 10:02 ` Jiri Slaby
[not found] <fSnJM-6IJ-11@gated-at.bofh.it>
[not found] ` <fSrkl-4sU-11@gated-at.bofh.it>
2010-11-25 13:20 ` Andreas Hartmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox