From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: akpm@linux-foundation.org, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [Use cpuops V1 02/11] vmstat: Optimize zone counter modifications through the use of this cpu operations
Date: Tue, 07 Dec 2010 15:00:24 +0100 [thread overview]
Message-ID: <4CFE3DF8.8080405@kernel.org> (raw)
In-Reply-To: <20101206171637.445023081@linux.com>
On 12/06/2010 06:16 PM, Christoph Lameter wrote:
> this cpu operations can be used to slightly optimize the function. The
> changes will avoid some address calculations and replace them with the
> use of the percpu segment register.
>
> If one would have this_cpu_inc_return and this_cpu_dec_return then it
> would be possible to optimize inc_zone_page_state and dec_zone_page_state even
> more.
>
> V1->V2:
> - Fix __dec_zone_state overflow handling
> - Use s8 variables for temporary storage.
>
> V2->V3:
> - Put __percpu annotations in correct places.
>
> Reviewed-by: Pekka Enberg <penberg@kernel.org>
> Signed-off-by: Christoph Lameter <cl@linux.com>
> @@ -221,16 +223,19 @@ EXPORT_SYMBOL(mod_zone_page_state);
...
> + __this_cpu_write(*p, - overstep);
Applied to percpu#for-next with the space after '-' removed from the
above line.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-12-07 14:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 17:16 [Use cpuops V1 00/11] Use this_cpu_ops Christoph Lameter
2010-12-06 17:16 ` [Use cpuops V1 01/11] percpucounter: Optimize __percpu_counter_add a bit through the use of this_cpu() options Christoph Lameter
2010-12-07 13:59 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 02/11] vmstat: Optimize zone counter modifications through the use of this cpu operations Christoph Lameter
2010-12-07 14:00 ` Tejun Heo [this message]
2010-12-06 17:16 ` [Use cpuops V1 03/11] x86: Use this_cpu_ops to optimize code Christoph Lameter
2010-12-06 17:16 ` [Use cpuops V1 04/11] x86: Use this_cpu_ops for current_cpu_data accesses Christoph Lameter
2010-12-07 14:17 ` Tejun Heo
2010-12-07 14:20 ` Tejun Heo
2010-12-07 14:46 ` Christoph Lameter
2010-12-07 14:59 ` Tejun Heo
2010-12-07 15:07 ` Christoph Lameter
2010-12-07 15:08 ` Tejun Heo
2010-12-07 16:21 ` Christoph Lameter
2010-12-08 13:16 ` [PATCH] x86: Replace uses of current_cpu_data with this_cpu ops Tejun Heo
2010-12-08 13:38 ` Eric Dumazet
2010-12-08 15:33 ` Christoph Lameter
2010-12-08 17:17 ` Eric Dumazet
2010-12-08 17:20 ` Tejun Heo
2010-12-08 17:33 ` Christoph Lameter
2010-12-08 17:57 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 05/11] core: Replace __get_cpu_var with __this_cpu_read if not used for an address Christoph Lameter
2010-12-07 14:29 ` Tejun Heo
2010-12-07 14:51 ` Christoph Lameter
2010-12-07 15:21 ` Tejun Heo
2010-12-07 15:38 ` Christoph Lameter
2010-12-08 15:24 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 06/11] drivers: " Christoph Lameter
2010-12-07 14:31 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 07/11] kprobes: Use this_cpu_ops Christoph Lameter
2010-12-07 15:03 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 08/11] Fakekey: Simplify speakup_fake_key_pressed through this_cpu_ops Christoph Lameter
2010-12-07 15:07 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 09/11] Connector: Use this_cpu operations Christoph Lameter
2010-12-07 15:08 ` Tejun Heo
2010-12-07 15:36 ` Christoph Lameter
2010-12-06 17:16 ` [Use cpuops V1 10/11] fs: Use this_cpu_xx operations in buffer.c Christoph Lameter
2010-12-07 15:16 ` Tejun Heo
2010-12-06 17:16 ` [Use cpuops V1 11/11] Xen: Use this_cpu_ops Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE3DF8.8080405@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).