From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Feng Tang <feng.tang@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Brown, Len" <len.brown@intel.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/platform] x86: Unify current 3 similar ways of saving IRQ info
Date: Tue, 07 Dec 2010 17:43:47 -0800 [thread overview]
Message-ID: <4CFEE2D3.6050107@kernel.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1012072327000.2653@localhost6.localdomain6>
On 12/07/2010 02:32 PM, Thomas Gleixner wrote:
> On Tue, 7 Dec 2010, Yinghai Lu wrote:
>> On 12/07/2010 07:56 AM, Thomas Gleixner wrote:
>>>
>>> Same here. No caller is interested in the detailed return value.
>>>
>>
>
>> ok, after look at code and git log, i knew the reasons for those
>> strange duplicated functions.
>>
>> Alexy changed
>>
>> /* MP IRQ source entries */
>> -struct mpc_config_intsrc mp_irqs[MAX_IRQ_SOURCES];
>> +struct mp_config_intsrc mp_irqs[MAX_IRQ_SOURCES];
>>
>> to make it decouple that with mpstable definition. so mptable will
>> have mpc_intsrc, and acpi etc will use mp_config_intsrc
>>
>> and he planed to add more member to mp_config_intsrc .... never happened.
>>
>> then I added those functions with different parameters.
>>
>> one year later JSR changed all back to mpc_instr...
>>
>> so now have some duplicated functions....
>
>> So yes, we should use simple versions in
>> arch/x86/kernel/acpi/boot.c. ( assume functions mrst.c are copied
>> from there)
>>
>> and should kill print_mp_irq_info or print_MP_intsrc_info...
>
> Nice archaelogical detective work ! :)
>
> So now I have Fengs patch plus Yinghais series which seem to go nicely
> together, but I have the feeling that there is some stuff unresolved.
>
> Yinghai, Feng: could you please work out the missing bits an pieces
> (if any) and provide me a delta patch on top of the existing patches?
>
Maybe Feng could send you updated version with simpler function?
Yinghai
next prev parent reply other threads:[~2010-12-08 1:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 4:11 [PATCH] x86: unify current 3 similar ways of saving IRQ info Feng Tang
2010-12-06 15:01 ` [tip:x86/platform] x86: Unify " tip-bot for Feng Tang
2010-12-06 17:50 ` Yinghai Lu
2010-12-06 19:51 ` Thomas Gleixner
2010-12-07 5:32 ` Feng Tang
2010-12-07 15:56 ` Thomas Gleixner
2010-12-07 18:43 ` Yinghai Lu
2010-12-07 22:32 ` Thomas Gleixner
2010-12-08 1:43 ` Yinghai Lu [this message]
2010-12-08 1:47 ` Yinghai Lu
2010-12-08 2:08 ` Feng Tang
2010-12-08 1:52 ` Feng Tang
2010-12-08 7:18 ` Feng Tang
2010-12-09 20:57 ` [tip:x86/apic-cleanups] x86: Further simplify mp_irq info handling tip-bot for Feng Tang
2010-12-09 20:56 ` [tip:x86/apic-cleanups] x86: Unify 3 similar ways of saving mp_irqs info tip-bot for Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFEE2D3.6050107@kernel.org \
--to=yinghai@kernel.org \
--cc=alan@linux.intel.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox