[PATCH] speakup: fakekey.c: Fix error: macro "__this_cpu_write" requires 2 arguments, but only 1 given

[PATCH] speakup: fakekey.c: Fix error: macro "__this_cpu_write" requires 2 arguments, but only 1 given

[Sedat Dilek]

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]

While building linux-next (next-20101208) I fell over this build failure.
The attached patch is compile-tested-only.

- Sedat -

[-- Attachment #2: 0001-speakup-fakekey.c-Fix-error-macro-__this_cpu_write-r.patch --]
[-- Type: text/x-diff, Size: 2053 bytes --]

From 4f25de85d29fa32751c879e645269119a3ef3579 Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@gmail.com>
Date: Wed, 8 Dec 2010 14:22:49 +0100
Subject: [PATCH] speakup:fakekey.c: Fix error: macro "__this_cpu_write" requires 2 arguments, but only 1 given
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From build.log:

drivers/staging/speakup/fakekey.c:81:38: error: macro "__this_cpu_write" requires 2 arguments, but only 1 given
drivers/staging/speakup/fakekey.c: In function ‘speakup_fake_down_arrow’:
drivers/staging/speakup/fakekey.c:81: error: ‘__this_cpu_write’ undeclared (first use in this function)
drivers/staging/speakup/fakekey.c:81: error: (Each undeclared identifier is reported only once
drivers/staging/speakup/fakekey.c:81: error: for each function it appears in.)
drivers/staging/speakup/fakekey.c:81: warning: left-hand operand of comma expression has no effect
drivers/staging/speakup/fakekey.c:81: warning: statement with no effect
drivers/staging/speakup/fakekey.c:81: error: expected ‘;’ before ‘)’ token
drivers/staging/speakup/fakekey.c:81: error: expected statement before ‘)’ token

Issue was introduced by:
   commit 6c9bf601b9097f83839baee09b9f3eaa099fc3f4
   "drivers: Replace __get_cpu_var with __this_cpu_read if not used for an address."

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 drivers/staging/speakup/fakekey.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index 9f2a7a1..1b34a87 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -78,7 +78,7 @@ void speakup_fake_down_arrow(void)
 	/* don't change CPU */
 	preempt_disable();
 
-	__this_cpu_write(reporting_keystroke), true);
+	__this_cpu_write(reporting_keystroke, true);
 	input_report_key(virt_keyboard, KEY_DOWN, PRESSED);
 	input_report_key(virt_keyboard, KEY_DOWN, RELEASED);
 	__this_cpu_write(reporting_keystroke, false);
-- 
1.7.2.3

Re: [PATCH] speakup: fakekey.c: Fix error: macro "__this_cpu_write" requires 2 arguments, but only 1 given

[Tejun Heo]

On 12/08/2010 02:38 PM, Sedat Dilek wrote:
> While building linux-next (next-20101208) I fell over this build failure.
> The attached patch is compile-tested-only.

Rolled into the original patch.  Thank you very much for catching it.

-- 
tejun