From: Randy Dunlap <randy.dunlap@oracle.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Corentin Chary <corentin.chary@gmail.com>,
sedat.dilek@gmail.com, Matthew Garrett <mjg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!)
Date: Wed, 08 Dec 2010 15:58:44 -0800 [thread overview]
Message-ID: <4D001BB4.4040906@oracle.com> (raw)
In-Reply-To: <20101208234950.GB15294@core.coreip.homeip.net>
On 12/08/10 15:49, Dmitry Torokhov wrote:
> On Wed, Dec 08, 2010 at 11:35:08PM +0000, David Woodhouse wrote:
>> On Wed, 2010-12-08 at 15:31 -0800, Dmitry Torokhov wrote:
>>> Even better tool would allow selecting the needed optios right there,
>>> without the need of moving away from teh current option.
>>
>> That's exactly what the Nemesis version of xconfig did, almost 15 years
>> ago.
>>
>>> And yet better tool would not even ask user and enable them on its
>>> own. Hey, but we have it! It's called "select".
>>
>> The tools could do that with 'depends on' too. Why make a distinction?
>
> To allow automatic/manual selection. Sometimes the only answer to
> "shoudl it be enabled" is "Yes". I.e. drivers that need polling need
> input-polldev support. There is no reason whatsoever to even ask user.
>
> Same thing for platform drivers. "Don't you also want to enable option for
> your keyboard and mouse to work? Go do that, you won't regret." "Well,
> duh!"
>
>>
>>> Seriously, select is dangerous. I wonder if a rule like "One can only
>>> select a symbol whose dependencies are all satisfied by the current
>>> symbol and/or its parents and the symbols they select or depend on"
>>> would not make select safe enough.
>>
>> "One can only select a symbol which isn't otherwise presented to the
>> user as a choice".
>
> Input-polldev _is_ presented as a choice in case user or distro want to
> use out of tree driver that depends on it. Does this mean we shoudl
> disallow selects on it? I don't think so.
To me it means that we have too many config options, but I'm sure that some
embedded people would disagree with that.
| GUI tools have means of presenting this, menuconfig and oldconfig have
| harder time...
Sure, I know that.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-12-09 0:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 8:17 linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!) Sedat Dilek
2010-12-08 9:12 ` Corentin Chary
2010-12-08 9:18 ` Sedat Dilek
2010-12-08 9:20 ` Berg, Johannes
2010-12-08 9:28 ` Sedat Dilek
2010-12-08 9:51 ` Sedat Dilek
2010-12-08 9:53 ` David Woodhouse
2010-12-08 10:12 ` Sedat Dilek
2010-12-08 17:46 ` Dmitry Torokhov
2010-12-08 21:51 ` Randy Dunlap
2010-12-08 22:12 ` Dmitry Torokhov
2010-12-08 22:37 ` Thadeu Lima de Souza Cascardo
2010-12-08 23:08 ` David Woodhouse
2010-12-08 23:31 ` Dmitry Torokhov
2010-12-08 23:35 ` David Woodhouse
2010-12-08 23:49 ` Dmitry Torokhov
2010-12-08 23:58 ` Randy Dunlap [this message]
2010-12-08 23:34 ` Randy Dunlap
2010-12-08 23:41 ` David Woodhouse
2010-12-08 23:52 ` Dmitry Torokhov
2010-12-08 17:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D001BB4.4040906@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=corentin.chary@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox