From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754927Ab0LIPNg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Dec 2010 10:13:36 -0500
Received: from adelie.canonical.com ([91.189.90.139]:39197 "EHLO
	adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753666Ab0LIPNe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Dec 2010 10:13:34 -0500
Message-ID: <4D00F217.6050609@canonical.com>
Date: Thu, 09 Dec 2010 07:13:27 -0800
From: Chase Douglas <chase.douglas@canonical.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6
MIME-Version: 1.0
To: Jiri Kosina <jkosina@suse.cz>
CC: Michael Poole <mdpoole@troilus.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad
References: <1291849685-2623-1-git-send-email-chase.douglas@canonical.com> <alpine.LNX.2.00.1012091440410.508@pobox.suse.cz>
In-Reply-To: <alpine.LNX.2.00.1012091440410.508@pobox.suse.cz>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/09/2010 05:41 AM, Jiri Kosina wrote:
> On Wed, 8 Dec 2010, Chase Douglas wrote:
> 
>> With the recent switch to having the hid layer handle standard axis
>> initialization, the Magic Trackpad now reports relative axes. This would
>> be fine in the normal mode, but the driver puts the device in multitouch
>> mode where no relative events are generated. Also, userspace software
>> depends on accurate axis information for device type detection. Thus,
>> ignoring the relative axes from the Magic Trackpad is best.
> 
> Applied, thank you. I take it this should better go into .37 still, right?

Yes, please.

Thanks,

-- Chase