From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] Fix when booting Xen+Linux under QEMU.
Date: Thu, 09 Dec 2010 13:12:10 -0800 [thread overview]
Message-ID: <4D01462A.4010808@goop.org> (raw)
In-Reply-To: <1291928497-5599-1-git-send-email-konrad.wilk@oracle.com>
On 12/09/2010 01:01 PM, Konrad Rzeszutek Wilk wrote:
> Please take a look. The first patch just cleans up the find_unbound_irq
> so it is easier to understand what it does.
>
> The second patch hardness the Xen IRQ (event channels) allocation finder
> if you try to boot a minimalistic 32-bit Linux kernel along with a
> Xen hypervisor under QEMU.
>
> We end up with a weird scenario where the nr_irq_gsi was greater than nr_irq
> by 16. This code hardness it by pointing out the issue to the user and tries
> to continue - BUT this might impact the PCI device allocation.
>
> Tested also on normal machine with no regressions found.
I think I'd prefer to:
1. move to using all dynamic irqs, and use the core kernel irq
allocator (ie, resurrect IanC's patches)
2. kill the ioapic dummy page hack (I'm assuming that would be
trivial - at least to make it all zero - because the kernel won't
care about the number of GSIs at that point)
J
next prev parent reply other threads:[~2010-12-09 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 21:01 [PATCH] Fix when booting Xen+Linux under QEMU Konrad Rzeszutek Wilk
2010-12-09 21:01 ` [PATCH 1/2] xen/irq: Cleanup the find_unbound_irq Konrad Rzeszutek Wilk
2010-12-09 21:01 ` [PATCH 2/2] xen/irq: Don't fall over when nr_irqs_gsi > nr_irqs Konrad Rzeszutek Wilk
2010-12-09 21:12 ` Jeremy Fitzhardinge [this message]
2010-12-10 3:55 ` [PATCH] Fix when booting Xen+Linux under QEMU Konrad Rzeszutek Wilk
2010-12-10 13:02 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D01462A.4010808@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox