Re: [PATCH] at91: Refactor Stamp9G20 and PControl G20 board file

[Nicolas Ferre <nicolas.ferre@atmel.com>]

Le 10/12/2010 09:44, Christian Glindkamp :
> On 2010-12-09 18:39, Igor Plyatov wrote:
>> Dear Christian,
>>
>>> As PControl G20 is a carrier board for the Stamp9G20 SoM, some code can
>>> be shared. Therefore board-stamp9g20.c is refactored to allow reusing the
>>> SoM initialization and board-pcontrol-g20.c is modified to use it.
>>>
>>> Signed-off-by: Christian Glindkamp <christian.glindkamp@taskit.de>
>>> ---
>>>
>>> How about this approach? Compile tested for PControl G20 and run time tested
>>> for Stamp9G20 EVB and PortuxG20.
>>>
>>> Just a side note: PortuxG20 is not a carrier board for the Stamp9G20. It just
>>> shares so much with the evaluation board, that it makes sense to put them both
>>> into the same file. And there is no intention to put other boards into this
>>> file.
>>
>> The idea from this patch is clean.

Seems clean to me also.

>> Yours patch does not apply to the kernel from
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git,
>> but I apply its content by hands and kernels compiled successfully with
>> stamp9g20_defconfig and pcontrol_g20_defconfig.
> 
> I used exactly this repository. Revision 6313e3c21743cc88bb5bd8aa72948ee1e83937b6
> to be precise. Maybe your mailer corrupted the patch.
> 
>> Please run ./scripts/checkpatch.pl with you patch and correct all errors
>> and warnings reported. 
> 
> I only get some "line over 80 characters" warnings, which can imho be
> ignored.
> 
>>
>> If you will correct this patch, to be applicable, then I will vote to
>> include it into mainline.
>>
>> Which kernel repository and branch should I use for the AT91 ARM?
>> I just want to know - whereto send my next patch to support gms machine?

You can build your "gms" patch on top of Linus' + Christian's patches.

Then, I will:
- send the patch series to mailing-list for final review (maybe with one
or two additional patches)
- prepare a pull-request for inclusion in mainline (.37-final may be ok
as it is just board additions)

Bye,
-- 
Nicolas Ferre