From: Chase Douglas <chase.douglas@canonical.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Takashi Iwai <tiwai@suse.de>,
Chris Bagwell <chris@cnpbagwell.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: synaptics - add multitouch packet support
Date: Mon, 13 Dec 2010 15:09:37 -0800 [thread overview]
Message-ID: <4D06A7B1.6060609@canonical.com> (raw)
In-Reply-To: <1292280948-1933-1-git-send-email-rydberg@euromail.se>
On 12/13/2010 02:55 PM, Henrik Rydberg wrote:
> @@ -638,7 +677,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)
> __set_bit(BTN_LEFT, dev->keybit);
> __set_bit(BTN_RIGHT, dev->keybit);
>
> - if (SYN_CAP_MULTIFINGER(priv->capabilities)) {
> + if (SYN_CAP_MULTIFINGER(priv->capabilities) | priv->multitouch) {
^^ Although I think this is functionally correct, it is nevertheless a
typo. Note that there's only one '|' where there should be two.
Henrik, do you want to fix this, or would you like me to fix and resend?
I've got no problems either way :).
Thanks,
-- Chase
next prev parent reply other threads:[~2010-12-13 23:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 22:55 [PATCH 1/2] Input: synaptics - add multitouch packet support Henrik Rydberg
2010-12-13 22:55 ` [PATCH 2/2] Input: synaptics - emit multitouch data Henrik Rydberg
2010-12-13 23:14 ` Chase Douglas
2010-12-13 23:09 ` Chase Douglas [this message]
2010-12-13 23:15 ` [PATCH 1/2] Input: synaptics - add multitouch packet support Henrik Rydberg
2010-12-14 21:37 ` Chase Douglas
2010-12-15 14:21 ` Henrik Rydberg
2010-12-15 17:47 ` Chase Douglas
2010-12-15 19:14 ` Chris Bagwell
2010-12-15 21:24 ` Chase Douglas
2010-12-15 23:42 ` Peter Hutterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D06A7B1.6060609@canonical.com \
--to=chase.douglas@canonical.com \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox