Re: [PATCH v3 2/4] genirq: Inform handler about line sharing state

Thomas Gleixner
2010-12-16T13:13:33Z

On Mon, 13 Dec 2010, Jan Kiszka wrote:
> + if (old_action && (old_action->flags & IRQF_ADAPTIVE) &&
> + !(desc->irq_data.drv_status & IRQS_SHARED)) {
> + /*
> + * Signal the old handler that is has to switch to shareable
> + * handling mode. Disable the line to avoid any conflict with
> + * a real IRQ.
> + */
> + disable_irq(irq);

This is weird, really. I thought you wanted to avoid waiting for the
threaded handler to finish if it's on the fly. So this should be
disable_irq_nosync() or did you change your mind ?

Thanks,

tglx