Re: [PATCH v3 1/4] genirq: Introduce driver-readable IRQ status word

Jan Kiszka
2010-12-14T23:10:12Z

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

Am 14.12.2010 21:47, Thomas Gleixner wrote:
> On Mon, 13 Dec 2010, Jan Kiszka wrote:
>> +/**
>> + * get_irq_status - read interrupt line status word
>> + * @irq: Interrupt line of the status word
>> + *
>> + * This returns the current content of the status word associated with
>> + * the given interrupt line. See IRQS_* flags for details.
>> + */
>> +unsigned long get_irq_status(unsigned int irq)
>> +{
>> + struct irq_desc *desc = irq_to_desc(irq);
>> +
>> + return desc ? desc->irq_data.drv_status : 0;
>> +}
>> +EXPORT_SYMBOL_GPL(get_irq_status);
>
> We should document that this is a snapshot and in no way serialized
> against modifications of drv_status. I'll fix up the kernel doc.

Yeah, I think I had some hint on this in the previous version but
apparently dropped it for this round.

Thanks,
Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]