From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux.com>, Tejun Heo <tj@kernel.org>,
Pekka Enbeerg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: x86: A fast way to check capabilities of the current cpu
Date: Wed, 15 Dec 2010 13:03:17 -0800 [thread overview]
Message-ID: <4D092D15.7030700@zytor.com> (raw)
In-Reply-To: <20101215125626.25f7d648.akpm@linux-foundation.org>
On 12/15/2010 12:56 PM, Andrew Morton wrote:
> On Wed, 15 Dec 2010 14:07:39 -0600 (CST)
> Christoph Lameter <cl@linux.com> wrote:
>
>> +#define cpu_has(c, bit) \
>> + (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
>> test_cpu_cap(c, bit))
>>
>> +#define this_cpu_has(bit) \
>> + (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
>> + this_cpu_test_bit(bit, (unsigned long *)&cpu_info.x86_capability))
>> +
>
> Isn't
>
> a ? 1 : b
>
> a complex way of writing
>
> a || b
>
Not if b is not a bool.
-hpa
next prev parent reply other threads:[~2010-12-15 21:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 20:07 x86: A fast way to check capabilities of the current cpu Christoph Lameter
2010-12-15 20:11 ` x86: Avoid passing struct cpuinfo pointer to mce_available Christoph Lameter
2010-12-15 20:56 ` x86: A fast way to check capabilities of the current cpu Andrew Morton
2010-12-15 21:03 ` H. Peter Anvin [this message]
2010-12-15 21:30 ` Miguel Ojeda
2010-12-15 21:39 ` H. Peter Anvin
2010-12-15 21:48 ` Miguel Ojeda
2010-12-16 6:25 ` Miles Bader
2010-12-16 10:17 ` Miguel Ojeda
2010-12-16 10:29 ` Miles Bader
2010-12-16 15:38 ` H. Peter Anvin
2010-12-17 4:26 ` Miles Bader
2011-01-21 17:11 ` Tejun Heo
2011-01-21 17:21 ` Christoph Lameter
2011-01-21 17:28 ` Tejun Heo
2011-01-21 17:46 ` Christoph Lameter
2011-01-21 17:48 ` Tejun Heo
2011-01-21 17:57 ` Christoph Lameter
2011-01-21 18:12 ` Tejun Heo
2011-01-21 18:20 ` Christoph Lameter
2011-01-21 22:32 ` H. Peter Anvin
2011-01-24 17:05 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D092D15.7030700@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=penberg@cs.helsinki.fi \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox