From: Tejun Heo <htejun@gmail.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
lkml <linux-kernel@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [patch 2/3] add new macros to make percpu readmostly section correctly align
Date: Thu, 16 Dec 2010 10:50:38 +0100 [thread overview]
Message-ID: <4D09E0EE.7040605@gmail.com> (raw)
In-Reply-To: <1292479000.2323.468.camel@sli10-conroe>
Hello, Shaohua.
On 12/16/2010 06:56 AM, Shaohua Li wrote:
>>>>> -#include <asm-generic/vmlinux.lds.h>
>>>>> #include <asm/asm-offsets.h>
>>>>> #include <asm/thread_info.h>
>>>>> #include <asm/page_types.h>
>>>>> #include <asm/cache.h>
>>>>> +#include <asm-generic/vmlinux.lds.h>
>>>>> #include <asm/boot.h>
>>>>
>>>> Why do we need this chunk?
>>> the cache size is defined in cache.h, so I need move vmlinux.lds.h after
>>> cache.h
>>
>> The right fix is to move the inclusion of cache.h to
>> asm-generic/vmlinux.lds.h. A quick audit only found sparc that
>> failed to guard non assembler stuff.
>
> with this, we need check every arch, at least doing a compile. I'm
> afraid I can't, sorry.
Not being able to cross build every arch is okay but you at least need
to make an effort to make things easily applicable to other archs and
avoid adding subtle ugliness like the above. Please at least try to
look at other arch codes and see how things can be made to work across
different archs. Setting up cross compilers for the major archs, for
example, sparc, power and ia64 isn't that difficult either.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-12-16 9:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 2:02 [patch 2/3] add new macros to make percpu readmostly section correctly align Shaohua Li
2010-12-10 15:14 ` Tejun Heo
2010-12-13 0:41 ` Shaohua Li
2010-12-13 9:47 ` Tejun Heo
2010-12-14 1:08 ` Shaohua Li
2010-12-14 9:58 ` Tejun Heo
2010-12-15 1:57 ` Shaohua Li
2010-12-15 14:08 ` Tejun Heo
2010-12-15 14:49 ` Tejun Heo
2010-12-16 0:55 ` Shaohua Li
2010-12-16 0:53 ` Shaohua Li
2010-12-16 5:46 ` Sam Ravnborg
2010-12-16 5:56 ` Shaohua Li
2010-12-16 9:50 ` Tejun Heo [this message]
2010-12-20 1:28 ` Shaohua Li
2010-12-20 15:55 ` Tejun Heo
2010-12-23 2:38 ` Shaohua Li
2010-12-27 12:14 ` Tejun Heo
2010-12-28 0:26 ` Shaohua Li
2010-12-28 11:13 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D09E0EE.7040605@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox