* [PATCH 2/3] plsit: remove debug lock assignment for plist_node
@ 2010-12-16 10:23 Lai Jiangshan
0 siblings, 0 replies; only message in thread
From: Lai Jiangshan @ 2010-12-16 10:23 UTC (permalink / raw)
To: Peter Zijlstra, John Kacur, James Bottomley, Ingo Molnar,
Rafael J. Wysocki, Thomas Gleixner, Darren Hart, Namhyung Kim,
linux-kernel
original code use &plist_node->plist as the faked plist_head
for plist_del(), these debug locks in the faked plist_head
are needed for CONFIG_DEBUG_PI_LIST.
But now we always pass the real plist_head to plist_del(),
the debug locks in plist_node will not be used, so we remove these
assignments.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/kernel/futex.c b/kernel/futex.c
index 6c4f67a..725834e 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -1032,9 +1032,6 @@ void requeue_futex(struct futex_q *q, struct futex_hash_bucket *hb1,
plist_del(&q->list, &hb1->chain);
plist_add(&q->list, &hb2->chain);
q->lock_ptr = &hb2->lock;
-#ifdef CONFIG_DEBUG_PI_LIST
- q->list.plist.spinlock = &hb2->lock;
-#endif
}
get_futex_key_refs(key2);
q->key = *key2;
@@ -1068,9 +1065,6 @@ void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key,
q->rt_waiter = NULL;
q->lock_ptr = &hb->lock;
-#ifdef CONFIG_DEBUG_PI_LIST
- q->list.plist.spinlock = &hb->lock;
-#endif
wake_up_state(q->task, TASK_NORMAL);
}
@@ -1418,9 +1412,6 @@ static inline void queue_me(struct futex_q *q, struct futex_hash_bucket *hb)
prio = min(current->normal_prio, MAX_RT_PRIO);
plist_node_init(&q->list, prio);
-#ifdef CONFIG_DEBUG_PI_LIST
- q->list.plist.spinlock = &hb->lock;
-#endif
plist_add(&q->list, &hb->chain);
q->task = current;
spin_unlock(&hb->lock);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-12-16 10:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-16 10:23 [PATCH 2/3] plsit: remove debug lock assignment for plist_node Lai Jiangshan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox