visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Geert Uytterhoeven]

On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
> please pull these kbuild/kconfig fixes for the next -rc. The largest
> part are fixes for the annoying kconfig warnings, contributed by Arnaud
> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
> keyword to the Kconfig language, so it's not exactly something that one
> would expect in the rc phase, but the kconfig change is not huge (the
> large diff is due to generated files) and it is deployed only in those
> five Kconfig files that had the warnings and were hard to fix by other
> means.  The second part is a forgotten patch by Hendrik Brueckner to
> usr/initramfs, that fixes build for Blackfin and h8300.

> Arnaud Lacombe (5):
>      kconfig: add an option to determine a menu's visibility

Hmm, this changeset also went in through the v4l tree?

BTW, I got confused:
  - make allmodconfig causes e.g.:
        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
        CONFIG_VIDEO_TVAUDIO=m
    => good
  - make oldconfig for my config with almost everything selected,
except for stuff I know that breaks:
        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
        # CONFIG_VIDEO_TVAUDIO is not set
    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
    => bad!

Is this intentional?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Arnaud Lacombe]

Hi,

On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>> keyword to the Kconfig language, so it's not exactly something that one
>> would expect in the rc phase, but the kconfig change is not huge (the
>> large diff is due to generated files) and it is deployed only in those
>> five Kconfig files that had the warnings and were hard to fix by other
>> means.  The second part is a forgotten patch by Hendrik Brueckner to
>> usr/initramfs, that fixes build for Blackfin and h8300.
>
>> Arnaud Lacombe (5):
>>      kconfig: add an option to determine a menu's visibility
>
> Hmm, this changeset also went in through the v4l tree?
>
Mauro merely imported the set in his tree to give them visibility and
testing, but they went in trough the kbuild tree after being in -next
for a week.

> BTW, I got confused:
>  - make allmodconfig causes e.g.:
>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>        CONFIG_VIDEO_TVAUDIO=m
>    => good
>  - make oldconfig for my config with almost everything selected,
> except for stuff I know that breaks:
>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>        # CONFIG_VIDEO_TVAUDIO is not set
>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>    => bad!
that's difficult to judge without your old configuration.
VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
information about.

 - Arnaud

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Geert Uytterhoeven]

On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe <lacombar@gmail.com> wrote:
> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
>>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>>> keyword to the Kconfig language, so it's not exactly something that one
>>> would expect in the rc phase, but the kconfig change is not huge (the
>>> large diff is due to generated files) and it is deployed only in those
>>> five Kconfig files that had the warnings and were hard to fix by other
>>> means.  The second part is a forgotten patch by Hendrik Brueckner to
>>> usr/initramfs, that fixes build for Blackfin and h8300.
>>
>>> Arnaud Lacombe (5):
>>>      kconfig: add an option to determine a menu's visibility
>>
>> Hmm, this changeset also went in through the v4l tree?
>>
> Mauro merely imported the set in his tree to give them visibility and
> testing, but they went in trough the kbuild tree after being in -next
> for a week.

Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't
show a SoB from Michal...

>> BTW, I got confused:
>>  - make allmodconfig causes e.g.:
>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>        CONFIG_VIDEO_TVAUDIO=m
>>    => good
>>  - make oldconfig for my config with almost everything selected,
>> except for stuff I know that breaks:
>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>        # CONFIG_VIDEO_TVAUDIO is not set
>>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>    => bad!
> that's difficult to judge without your old configuration.
> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
> information about.

I don't have PCI, so I cannot enable VIDEO_BT848.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Arnaud Lacombe]

Hi,

On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
>>>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>>>> keyword to the Kconfig language, so it's not exactly something that one
>>>> would expect in the rc phase, but the kconfig change is not huge (the
>>>> large diff is due to generated files) and it is deployed only in those
>>>> five Kconfig files that had the warnings and were hard to fix by other
>>>> means.  The second part is a forgotten patch by Hendrik Brueckner to
>>>> usr/initramfs, that fixes build for Blackfin and h8300.
>>>
>>>> Arnaud Lacombe (5):
>>>>      kconfig: add an option to determine a menu's visibility
>>>
>>> Hmm, this changeset also went in through the v4l tree?
>>>
>> Mauro merely imported the set in his tree to give them visibility and
>> testing, but they went in trough the kbuild tree after being in -next
>> for a week.
>
> Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't
> show a SoB from Michal...
>
Why would you expect it to ? Most of the commit in Linus' tree are not
personally SoB by him.

>>> BTW, I got confused:
>>>  - make allmodconfig causes e.g.:
>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>        CONFIG_VIDEO_TVAUDIO=m
>>>    => good
>>>  - make oldconfig for my config with almost everything selected,
>>> except for stuff I know that breaks:
>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>        # CONFIG_VIDEO_TVAUDIO is not set
>>>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>>    => bad!
>> that's difficult to judge without your old configuration.
>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
>> information about.
>
> I don't have PCI, so I cannot enable VIDEO_BT848.
>
so why do you expect VIDEO_TVAUDIO to be enabled ?

 - Arnaud

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Geert Uytterhoeven]

On Tue, Dec 7, 2010 at 21:40, Arnaud Lacombe <lacombar@gmail.com> wrote:
> On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe <lacombar@gmail.com> wrote:
>>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
>>>>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>>>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>>>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>>>>> keyword to the Kconfig language, so it's not exactly something that one
>>>>> would expect in the rc phase, but the kconfig change is not huge (the
>>>>> large diff is due to generated files) and it is deployed only in those
>>>>> five Kconfig files that had the warnings and were hard to fix by other
>>>>> means.  The second part is a forgotten patch by Hendrik Brueckner to
>>>>> usr/initramfs, that fixes build for Blackfin and h8300.
>>>>
>>>>> Arnaud Lacombe (5):
>>>>>      kconfig: add an option to determine a menu's visibility
>>>>
>>>> Hmm, this changeset also went in through the v4l tree?
>>>>
>>> Mauro merely imported the set in his tree to give them visibility and
>>> testing, but they went in trough the kbuild tree after being in -next
>>> for a week.
>>
>> Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't
>> show a SoB from Michal...
>>
> Why would you expect it to ? Most of the commit in Linus' tree are not
> personally SoB by him.

Sorry, you're right.

>>>> BTW, I got confused:
>>>>  - make allmodconfig causes e.g.:
>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>        CONFIG_VIDEO_TVAUDIO=m
>>>>    => good
>>>>  - make oldconfig for my config with almost everything selected,
>>>> except for stuff I know that breaks:
>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>        # CONFIG_VIDEO_TVAUDIO is not set
>>>>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>>>    => bad!
>>> that's difficult to judge without your old configuration.
>>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
>>> information about.
>>
>> I don't have PCI, so I cannot enable VIDEO_BT848.
>>
> so why do you expect VIDEO_TVAUDIO to be enabled ?

I don't expect it to be enabled, I expected to be able to enable it.
Allmodconfig
does enable it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Mauro Carvalho Chehab]

Em 07-12-2010 18:45, Geert Uytterhoeven escreveu:
> On Tue, Dec 7, 2010 at 21:40, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe <lacombar@gmail.com> wrote:
>>>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>>> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
>>>>>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>>>>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>>>>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>>>>>> keyword to the Kconfig language, so it's not exactly something that one
>>>>>> would expect in the rc phase, but the kconfig change is not huge (the
>>>>>> large diff is due to generated files) and it is deployed only in those
>>>>>> five Kconfig files that had the warnings and were hard to fix by other
>>>>>> means.  The second part is a forgotten patch by Hendrik Brueckner to
>>>>>> usr/initramfs, that fixes build for Blackfin and h8300.
>>>>>
>>>>>> Arnaud Lacombe (5):
>>>>>>      kconfig: add an option to determine a menu's visibility
>>>>>
>>>>> Hmm, this changeset also went in through the v4l tree?
>>>>>
>>>> Mauro merely imported the set in his tree to give them visibility and
>>>> testing, but they went in trough the kbuild tree after being in -next
>>>> for a week.
>>>
>>> Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't
>>> show a SoB from Michal...
>>>
>> Why would you expect it to ? Most of the commit in Linus' tree are not
>> personally SoB by him.
> 
> Sorry, you're right.
> 
>>>>> BTW, I got confused:
>>>>>  - make allmodconfig causes e.g.:
>>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>>        CONFIG_VIDEO_TVAUDIO=m
>>>>>    => good
>>>>>  - make oldconfig for my config with almost everything selected,
>>>>> except for stuff I know that breaks:
>>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>>        # CONFIG_VIDEO_TVAUDIO is not set
>>>>>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>>>>    => bad!
>>>> that's difficult to judge without your old configuration.
>>>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
>>>> information about.
>>>
>>> I don't have PCI, so I cannot enable VIDEO_BT848.
>>>
>> so why do you expect VIDEO_TVAUDIO to be enabled ?
> 
> I don't expect it to be enabled, I expected to be able to enable it.
> Allmodconfig
> does enable it.

Why do you want to enable a device that doesn't work? There's no other driver
but bttv that has upport for the devices implemented by tvaudio module.

/me is confused...

Cheers,
Mauro

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Geert Uytterhoeven]

On Tue, Dec 7, 2010 at 23:36, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> Em 07-12-2010 18:45, Geert Uytterhoeven escreveu:
>> On Tue, Dec 7, 2010 at 21:40, Arnaud Lacombe <lacombar@gmail.com> wrote:
>>> On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe <lacombar@gmail.com> wrote:
>>>>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>>>> On Sat, Dec 4, 2010 at 14:57, Michal Marek <mmarek@suse.cz> wrote:
>>>>>>> please pull these kbuild/kconfig fixes for the next -rc. The largest
>>>>>>> part are fixes for the annoying kconfig warnings, contributed by Arnaud
>>>>>>> Lacombe and Mauro Carvalho Chehab. The solution adds a new 'visible if'
>>>>>>> keyword to the Kconfig language, so it's not exactly something that one
>>>>>>> would expect in the rc phase, but the kconfig change is not huge (the
>>>>>>> large diff is due to generated files) and it is deployed only in those
>>>>>>> five Kconfig files that had the warnings and were hard to fix by other
>>>>>>> means.  The second part is a forgotten patch by Hendrik Brueckner to
>>>>>>> usr/initramfs, that fixes build for Blackfin and h8300.
>>>>>>
>>>>>>> Arnaud Lacombe (5):
>>>>>>>      kconfig: add an option to determine a menu's visibility
>>>>>>
>>>>>> Hmm, this changeset also went in through the v4l tree?
>>>>>>
>>>>> Mauro merely imported the set in his tree to give them visibility and
>>>>> testing, but they went in trough the kbuild tree after being in -next
>>>>> for a week.
>>>>
>>>> Hmm, git show 86e187ff9bce9fbed7bfed92ae34f491cf1af50f doesn't
>>>> show a SoB from Michal...
>>>>
>>> Why would you expect it to ? Most of the commit in Linus' tree are not
>>> personally SoB by him.
>>
>> Sorry, you're right.
>>
>>>>>> BTW, I got confused:
>>>>>>  - make allmodconfig causes e.g.:
>>>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>>>        CONFIG_VIDEO_TVAUDIO=m
>>>>>>    => good
>>>>>>  - make oldconfig for my config with almost everything selected,
>>>>>> except for stuff I know that breaks:
>>>>>>        CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>>>        # CONFIG_VIDEO_TVAUDIO is not set
>>>>>>    and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>>>>>    => bad!
>>>>> that's difficult to judge without your old configuration.
>>>>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
>>>>> information about.
>>>>
>>>> I don't have PCI, so I cannot enable VIDEO_BT848.
>>>>
>>> so why do you expect VIDEO_TVAUDIO to be enabled ?
>>
>> I don't expect it to be enabled, I expected to be able to enable it.
>> Allmodconfig
>> does enable it.
>
> Why do you want to enable a device that doesn't work? There's no other driver
> but bttv that has upport for the devices implemented by tvaudio module.
>
> /me is confused...

Compile coverage?

Haven't checked yet whether it gets enabled with allyesconfig, but allyesconfig
contains a few things that don't work.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: visibility changes (was: Re: [GIT] kbuild and kconfig fixes for 2.6.37-rc5)

[Michal Marek]

On 7.12.2010 21:45, Geert Uytterhoeven wrote:
> On Tue, Dec 7, 2010 at 21:40, Arnaud Lacombe<lacombar@gmail.com>  wrote:
>> On Tue, Dec 7, 2010 at 3:31 PM, Geert Uytterhoeven<geert@linux-m68k.org>  wrote:
>>> On Tue, Dec 7, 2010 at 20:51, Arnaud Lacombe<lacombar@gmail.com>  wrote:
>>>> On Tue, Dec 7, 2010 at 2:07 PM, Geert Uytterhoeven<geert@linux-m68k.org>  wrote:
>>>>> BTW, I got confused:
>>>>>   - make allmodconfig causes e.g.:
>>>>>         CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>>         CONFIG_VIDEO_TVAUDIO=m
>>>>>     =>  good
>>>>>   - make oldconfig for my config with almost everything selected,
>>>>> except for stuff I know that breaks:
>>>>>         CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
>>>>>         # CONFIG_VIDEO_TVAUDIO is not set
>>>>>     and no way to manually set CONFIG_VIDEO_TVAUDIO=y?
>>>>>     =>  bad!
>>>> that's difficult to judge without your old configuration.
>>>> VIDEO_TVAUDIO is only selected by VIDEO_BT848 which you don't give
>>>> information about.
>>>
>>> I don't have PCI, so I cannot enable VIDEO_BT848.
>>>
>> so why do you expect VIDEO_TVAUDIO to be enabled ?
>
> I don't expect it to be enabled, I expected to be able to enable it.
> Allmodconfig
> does enable it.

Actually allmodconfig should not enable it, as it did not so before the 
patch. See Jan's fix at https://patchwork.kernel.org/patch/393302/

Michal