Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interrupts disabled internally

Nicholas A. Bellinger
2010-12-23T21:40:54Z

On Tue, 2010-12-21 at 17:43 -0600, Mike Christie wrote:
> On 12/21/2010 04:53 AM, Boaz Harrosh wrote:
> > On 12/21/2010 02:42 AM, Mike Christie wrote:
> >> On 12/19/2010 03:21 PM, Nicholas A. Bellinger wrote:
> >>> prepd_fault:
> >>> @@ -1732,12 +1728,10 @@ fault:
> >>> scsi_out(sc)->resid = scsi_out(sc)->length;
> >>> scsi_in(sc)->resid = scsi_in(sc)->length;
> >>> }
> >>> - done(sc);
> >>> - spin_lock(host->host_lock);
> >>> + sc->scsi_done(sc);
> >>> return 0;
> >>
> >>
> >> Did you mean to send this patch or a different one? I think you sent a
> >> patch with this before and I said it was wrong. Did you disagree with
> >> that comment or did you change something else so it now works?
> >
> > Mike hi
> >
> > I think Nick is gone for the holidays. What I understood is that he's
> > waiting for you to fix it. Because he's not sure what the proper solution
> > is. Do you have time to look into it? (It will take you much faster then me)
> >
>
> I am still working on it for the 2.6.38 feature window.

I was still unsure on the exception path handling concerns you had
mentioned in iscsi_queuecommand() wrt to a NULL pointer deference with
sc->scsi_done() for SCSI_MLQUEUE_TARGET_BUSY. So at this point I will
again defer to your better judgement and await your patch.

Thanks Mike!

--nab